feat: add remaining tmp extentions #229
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egalvis27
commented
Jan 28, 2026
| return this.right(0); | ||
| } catch (err) { | ||
| if (path.includes('.goutputstream-')) { | ||
| if (TemporalFile.isTemporaryPath(path)) { |
Author
There was a problem hiding this comment.
Only one type of temporary file extension was being validated, which is problematic because different editors generate temporary files with varying extensions.
|
egalvis27
commented
Jan 28, 2026
| try { | ||
| const path = new TemporalFilePath(pathString); | ||
| const file = new TemporalFile(new Date(), path, new TemporalFileSize(0), new Date()); | ||
| return file.isAuxiliary(); |
Author
There was a problem hiding this comment.
There are cases where we need to validate a temporary file that is in transit—meaning it doesn't yet exist physically, but we still need to identify it. This static function was created to perform validation without requiring the file's metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is Changed / Added
Added the following extensions: ['.swp', '.swo', '.swn', '.swm']
Why
In Linux, different text editors create temporary files with varying extensions, and not all of these extensions were being handled properly.