Add configs for pdf-diff server and pdf diffType + Add condition to c…#198
Open
PhatLeBao-Phat wants to merge 1 commit intointernetarchive:masterfrom
Open
Add configs for pdf-diff server and pdf diffType + Add condition to c…#198PhatLeBao-Phat wants to merge 1 commit intointernetarchive:masterfrom
PhatLeBao-Phat wants to merge 1 commit intointernetarchive:masterfrom
Conversation
…heck mediaType and route to pdf-diff server and pdf diffType
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
We want to add support for PDF diff. This involves implementing a backend server to handle diff operations between PDF(s). The frontend needs to check
mediaTypeand route the request to the appropriate backend server with the correctdiffType.Change (breakable)
conf.jsonto point to the correct server endpoint (I assume this config is overwritten in prod env, thus, that prod config needs to be updated with this attribute as well)DiffTypediffType