chore: bump smpclient to 7.0.1 and == pin runtime deps#98
Merged
Conversation
smpclient 7.0.1 fixes the BLE connect hang on peer disconnect mid-pairing (#97) and tightens its bleak floor to >=3.0.2,<4 to avoid the AcquireNotify regression in bleak 2.0.x. Also `==` pins the direct runtime deps (typer, readchar) to current locked versions — smpmgr is an app, not a library, so leaving floors unpinned just risks downstream installs picking surprising versions. Dev deps continue to track the lock file.
There was a problem hiding this comment.
Pull request overview
Updates runtime dependency pinning to ensure reproducible installs and pulls in smpclient==7.0.1, which (per PR description) includes the upstream fix for the BLE connect hang on peer disconnect mid-pairing (issue #97).
Changes:
- Pin
smpclientto==7.0.1(withextras = ["all"]preserved). - Pin other direct runtime dependencies (
typer,readchar) to exact versions. - Regenerate
poetry.lock, resulting inbleak==3.0.2resolution and updated environment markers/normalized dependency names.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Pins direct runtime dependencies to exact versions, including smpclient==7.0.1. |
| poetry.lock | Updates resolved dependency graph (notably bleak==3.0.2) and refreshes markers/metadata from the lock regeneration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
davedesro
approved these changes
May 22, 2026
Contributor
|
Seems to work as expected. Built from this PR: With long timeout so the device will disconnect first, after 30s: With short timeout: |
Collaborator
Author
|
Thanks for testing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
smpclientto==7.0.1, which fixes the BLE connect hang on peer disconnect mid-pairing — the root cause behind Regression in 0.18.0: Stuck on Connecting... even after closed BLE connection #97. Fix landed in intercreate/smpclient#108.==pins the other runtime deps (typer,readchar) to current locked versions. smpmgr is an app, not a library, so leaving floors unpinned just risks downstream installs picking surprising versions. Dev deps still float per the lock file.poetry.lockregenerated;bleakis now resolved to3.0.2(smpclient 7.0.1 floor), up from2.1.1.Closes #97 once a release is cut.
Test plan
poetry lockresolves cleanly tosmpclient==7.0.1,bleak==3.0.2.lint(black / isort / flake8 / mypy) clean.testpasses.🤖 Generated with Claude Code