Conversation
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
34c73f0 to
2c576e6
Compare
765d4df to
86cd898
Compare
86cd898 to
a3e0223
Compare
|
@jasonpraful |
brianpburns
left a comment
There was a problem hiding this comment.
Nice job man! Some good cleanup outside of the arch update as well.
I think completely splitting the new and old architecture versus the inheritance approach I was testing is a much better call. It'll be much easier to deal with going forward.
I see you tackled the event listener updates in a separate PR as well. I figured that would be a breaking change.
I imagine you're going with the opt-in flow for now and it'll likely be an opt-out flow once stable?
|
Changes
Adds support for React native's new architecture with Backwards compatibility.
New Architecture
newarchandoldarchwith conditional compilation based on thenewArchEnabledflag.RCT_NEW_ARCH_ENABLEDmacro to switch between TurboModule and Bridge implementation.NativeIntercomSpec.tsUsage
No changes for existing users on old architecture. Enable new architecture with:
newArchEnabled=trueingradle.properties.RCT_NEW_ARCH_ENABLED=1 pod installTesting
READMEfor SDK setup.Other minor changes
Next Steps
A follow-up PR will be raised which adds an Expo example app with the new architecture.
References