fix(types): Pick email & userId for loginUserWithUserAttributes#278
Merged
jasonpraful merged 2 commits intointercom:mainfrom Aug 28, 2025
Merged
fix(types): Pick email & userId for loginUserWithUserAttributes#278jasonpraful merged 2 commits intointercom:mainfrom
jasonpraful merged 2 commits intointercom:mainfrom
Conversation
|
OMG please merge this. I had the same issue, and turns out the types are wrong and misleading. I came here to make the exact same PR. happy this exists already. |
Contributor
Author
@pavlos-sqds I've changed it using patch-package. |
jasonpraful
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started implementing intercom in a react-native project and when I looked at the types for
loginUserWithUserAttributesI saw that i could pass the following:This didn't seem to work, as I needed to login first, and update the user after. All data I passed to this function was ignored (besides email & userId).
If I look at the native implementation I can see that only
email&userIdcan be provided to theloginUserWithUserAttributesfunction.If I missed anything, feel free to guide me towards the proper implementation.
Thanks for making this open source 🙏