Update API version enum to include versions 2.12, 2.13, and 2.14#299
Conversation
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
VedranZoricic
force-pushed
the
update-api-version-enum-to-2-14
branch
from
81d57ed to
91edebc
Compare
|
Where is this seen in the spec? 🤔 |
|
| - '2.9' | ||
| - '2.10' | ||
| - '2.11' | ||
| - '2.12' |
There was a problem hiding this comment.
I think it makes sense to only include till it's version as per the name, like for this file till 2.10.
There was a problem hiding this comment.
Good point, fixed it
There was a problem hiding this comment.
I also removed Unstable from all the versions except unstable, let me know what you think
There was a problem hiding this comment.
Yep, that makes sense. Thank you!
|
I agree with Varshini's comment here. Also we should make sure to update the developer docs i.e https://github.com/intercom/developer-docs/blob/6f99080838e09cb23122748074c0be057a64518c/docs/references/%402.9/rest-api/api.intercom.io.yaml#L14300-L14318. |
| - '2.9' | ||
| - '2.10' | ||
| - '2.11' | ||
| - '2.12' |
There was a problem hiding this comment.
The versions later than 2.11 can be removed here.
There was a problem hiding this comment.
Nice catch, sorry for missing this. I had a merge conflict and I messed it up...
3 participants
Doing this as part of the changes for the multibrand API: https://github.com/intercom/intercom/issues/421822
Added the missing API versions (2.12, 2.13, and 2.14) to all the OpenAPI description files.