single-filter-search-request strict typechecking idea#224
Closed
patrickthornton wants to merge 13 commits intointercom:mainfrom
Closed
single-filter-search-request strict typechecking idea#224patrickthornton wants to merge 13 commits intointercom:mainfrom
patrickthornton wants to merge 13 commits intointercom:mainfrom
Conversation
revert version
try github token directly
discriminated union using oneOf adds strict typechecks for single filter queries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ditches operator and value in the single filter search request interface in favor of a filter attribute, which is a union of four different pairs of operators/values with appropriate type demands respective to each; this is a hellaciously breaking change, though, so i wanted your input on it!