This repository was archived by the owner on Aug 5, 2022. It is now read-only.
rename the generated header to parser.hpp #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We've changed parser to be pure C parser. I'm not sure why cmake expects .hpp, maybe because of https://github.com/01org/wds/blob/master/CMakeLists.txt#L3 ? I think it would be better to tell to cmake to treat generated parser as C code. |
By default cmake assumes parser.hpp is generated.
michaelolbrich
force-pushed
the
file_rename
branch
from
6ae3439 to
64c70a7
Compare
Contributor
Author
|
I think the header file name is derived from the source file name: cpp -> hpp. Anyways, since cmake 3.4 there is an option to set the filename. Patch updated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake expects this name an generated the corresponding dependencies.
Without this the files are always regenerated.