src_c/IMB_ones_accu.c: Fix RMA synchronization and buffer initialization #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 28, 2026 09:33
- Added proper MPI_Win_fence calls to ensure all MPI_Accumulate operations occur within valid RMA epochs (per-iteration for NON-AGGREGATE mode, single epoch for AGGREGATE mode). - Initialized target buffer before the first RMA operation to prevent validation errors on sample #0 when CHECK is enabled. - Added MPI_Barrier for synchronization after initialization. - Updated comments to English for clarity. This resolves issues with "Got invalid buffer" during validation and "Wrong synchronization of RMA calls" runtime errors.
- Measure only fence → Accumulate → fence (exclude init/validation/barriers). - Move target initialization and CHK_DIFF outside the timed region. - Normalize AGGREGATE time by r_cache_iter when CHECK is enabled. Improves accuracy of AGGREGATE and NON-AGGREGATE results with -DCHECK.
JuliaRS
force-pushed
the
imb_ext_accumulate
branch
from
3a406e7 to
ddd6f5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added proper MPI_Win_fence calls to ensure all MPI_Accumulate operations occur within valid RMA epochs (per-iteration for NON-AGGREGATE mode, single epoch for AGGREGATE mode).
Initialized target buffer before the first RMA operation to prevent validation errors on sample #0 when CHECK is enabled.
Added MPI_Barrier for synchronization after initialization.
Updated comments to English for clarity.
This resolves issues with "Got invalid buffer" during validation and "Wrong synchronization of RMA calls" runtime errors.