[SYCL] Fix SPIR-V type requirements for image operations#21937
Open
Seanst98 wants to merge 2 commits intointel:syclfrom
Open
[SYCL] Fix SPIR-V type requirements for image operations#21937Seanst98 wants to merge 2 commits intointel:syclfrom
Seanst98 wants to merge 2 commits intointel:syclfrom
Conversation
The SPIR-V OpenCL environment spec requires OpImageRead, OpImageWrite, OpImageFetch, and OpImageSampleExplicitLod to use vec4 operands with 32-bit component types (or 16-bit for half). Channel sizes and narrow integer types (8-bit and 16-bit) must be widened to their vec4 32-bit equivalents for the SPIR-V instruction. All __invoke__Image* functions now use these helpers to ensure correct SPIR-V type generation.
sergey-semenov
approved these changes
May 5, 2026
Contributor
Author
|
Hi @sergey-semenov, thanks for the review! Could you please add any relevant reviewer who could kickoff CI and get this merged? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SPIR-V OpenCL environment spec requires OpImageRead, OpImageWrite, OpImageFetch, and OpImageSampleExplicitLod to use vec4 operands with 32-bit component types (or 16-bit for half). Channel sizes and narrow integer types (8-bit and 16-bit) must be widened to their vec4 32-bit equivalents for the SPIR-V instruction.
All __invoke__Image* functions now use these helpers to ensure correct SPIR-V type generation.
Addresses: #21366