[SYCL] Use global_var_host_access ext for device_global on SPIR-V#21351
Open
Maetveis wants to merge 2 commits intointel:syclfrom
Open
[SYCL] Use global_var_host_access ext for device_global on SPIR-V#21351Maetveis wants to merge 2 commits intointel:syclfrom
Maetveis wants to merge 2 commits intointel:syclfrom
Conversation
Change the lowering of the `sycl-host-access` attribute to use the `SPV_INTEL_global_variable_host_access` extension instead of the deprecated `SPV_INTEL_global_variable_decorations` extension. Newly compiled applications will need to use a recent version of IGC that supports the new extension, but IGC has implemented the support for the new extension more than 6 months ago (in version 2.16.0), so I believe this is ok to do now.
Contributor
Author
These Windows failures seem related I'm looking into them. |
Contributor
Author
Yep, all of these use |
YuriPlyakhin
approved these changes
Feb 25, 2026
Contributor
YuriPlyakhin
left a comment
There was a problem hiding this comment.
Changes in files owned by me look good.
Not sure about when is the good time to merge the PR, since it will break customers, if they are using older GPU drivers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the lowering of the
sycl-host-accessattribute to use theSPV_INTEL_global_variable_host_accessextension instead of the deprecatedSPV_INTEL_global_variable_decorationsextension.Newly compiled applications will need to use a recent version of IGC that supports the new extension, but IGC has implemented the support for the new extension more than 6 months ago (in version 2.16.0), so I believe this is ok to do now.