[SYCL] Fix bindless image sample instruction generation#21345
Open
0x12CC wants to merge 2 commits intointel:syclfrom
Open
[SYCL] Fix bindless image sample instruction generation#213450x12CC wants to merge 2 commits intointel:syclfrom
0x12CC wants to merge 2 commits intointel:syclfrom
Conversation
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Contributor
Author
|
@slawekptak, friendly ping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SPIR-V specification requires the result type of the
OpImageSampleExplicitLodinstruction to be a vector of four components. The SYCL bindless images extension allows the user to specify a return type for thesample_imagecall that may not be a vector. This commit ensures the SYCL headers correctly convert between the user-specified type and the type required by the SPIR-V specification to prevent generating invalid SPIR-V modules.