Skip to content

[CI] Move clang-tidy to a separate workflow #21342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KornevNikita merged 1 commit into from
Mar 5, 2026
Merged

[CI] Move clang-tidy to a separate workflow #21342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .github/workflows/sycl-clang-tidy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,25 @@
name: clang-tidy

on:
workflow_call:
pull_request:
branches:
- sycl
paths:
- "**/*.cpp"
- "**/*.h"
- "**/*.hpp"


concurrency:
# Cancel a currently running workflow from the same PR, branch or tag.
Copy link
Copy Markdown
Contributor

@sarnex sarnex Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to be but what do we get from moving it to a separate workflow instead of inside precommit? just clearer to see the results?

Copy link
Copy Markdown
Contributor Author

@KornevNikita KornevNikita Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just clearer to see the results?

Exactly! The second thing - we can natively limit changed file types to trigger the workflow.

Copy link
Copy Markdown
Contributor

@sarnex sarnex Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thx

group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

permissions: read-all

jobs:
run-clang-tidy:
if: ${{ !contains(github.event.pull_request.labels.*.name, 'disable-lint') }}
runs-on: [Linux, build]
container:
image: ghcr.io/intel/llvm/sycl_ubuntu2404_nightly:latest
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/sycl-linux-precommit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,6 @@ jobs:
e2e_binaries_preview_artifact: e2e_bin_preview
e2e_binaries_new_offload_model_artifact: e2e_bin_new_offload_model

clang-tidy:
if: ${{ !contains(github.event.pull_request.labels.*.name, 'disable-lint') }}
uses: ./.github/workflows/sycl-clang-tidy.yml

# Build and run native cpu e2e tests separately as cannot currently
# build all the e2e tests
build_run_native_cpu_e2e_tests:
Expand Down
Loading