Skip to content

Conversation

@dkhaldi
Copy link
Contributor

@dkhaldi dkhaldi commented Dec 5, 2025

No description provided.

@dkhaldi dkhaldi marked this pull request as ready for review December 5, 2025 17:00
@dkhaldi dkhaldi requested a review from a team as a code owner December 5, 2025 17:00
// SG size = 32 is not currently supported for SYCL Joint Matrix by IGC on DG2
// UNSUPPORTED: gpu-intel-dg2

// XFAIL: windows && (arch-intel_gpu_ptl_u || arch-intel_gpu_ptl_h || intel_gpu_lnl_m)
Copy link
Contributor

@YixingZhang007 YixingZhang007 Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the Matrix/SG32/get_coordinate_ops.cpp and Matrix/element_wise_ops.cpp SYCL E2E tests appear to be passing when I run them on LNL Windows machine with driver version 20251112_160000 (Details can be found at Jira issue CMPLRLLVM-71724). I guess we might consider waiting for the confirmation from @wanyaman before making changes to these two tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the test still failed in 1206 Xmain nightly testing.
The driver version for reproducing this issue is IGFX: 101.8247.

@YixingZhang007
Copy link
Contributor

YixingZhang007 commented Jan 5, 2026

Matrix/SG32/get_coordinate_ops.cpp is now passing (explained in CMPLRLLVM-71724). I have created a separate PR to add XFAIL to test Matrix/element_wise_ops.cpp with an description. New PR can be found at #21003

@dkhaldi
Copy link
Contributor Author

dkhaldi commented Jan 5, 2026

Replaced by #21003 for Matrix/element_wise_ops.cpp
Matrix/SG32/get_coordinate_ops.cpp is still handled in this PR

@dkhaldi dkhaldi changed the title [E2E Tests] test fail on windows PTL and LNL [E2E Tests] test fail on windows WCL Jan 6, 2026
Copy link
Contributor

@YixingZhang007 YixingZhang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you :)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

@intel/llvm-gatekeepers please consider merging

@dkhaldi
Copy link
Contributor Author

dkhaldi commented Jan 6, 2026

@intel/llvm-gatekeepers, please consider merging this PR that has been approved and CI passed.

@sarnex
Copy link
Contributor

sarnex commented Jan 6, 2026

could you please give the pr a more specific title?

@dkhaldi dkhaldi changed the title [E2E Tests] test fail on windows WCL [SYCL][E2E] Add xfail to SG32/get_coordinate_ops.cpp test on windows WCL machine Jan 6, 2026
@dkhaldi dkhaldi changed the title [SYCL][E2E] Add xfail to SG32/get_coordinate_ops.cpp test on windows WCL machine [SYCL][E2E] Add xfail to SG32/get_coordinate_ops.cpp test on WCL windows machine Jan 6, 2026
@dkhaldi
Copy link
Contributor Author

dkhaldi commented Jan 6, 2026

could you please give the pr a more specific title?

How about now?

@sarnex
Copy link
Contributor

sarnex commented Jan 6, 2026

thanks!

@sarnex sarnex merged commit 4224af5 into sycl Jan 6, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants