fortran: fix windows fortran linking by removing dead 32-bit code #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichepiga
approved these changes
Jan 23, 2026
alexey-kireev
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the conditional compilation logic for
intel64inittnotify.f90.Since 32-bit Fortran support is dropped, the
!DEC$IFlogic was unnecessary and caused linking errors (unresolved external___itt_*) when theintel64macro wasn't manually defined. This change simplifies the interface to always use the 64-bit function pointers (__itt_*), resolving the linking issues on 64-bit Windows.