Using optimized funcs std::find, strchr with char param, constexpr calc len out-of-loop#791
Closed
GermanAizek wants to merge 2 commits into
Closed
Using optimized funcs std::find, strchr with char param, constexpr calc len out-of-loop#791GermanAizek wants to merge 2 commits into
GermanAizek wants to merge 2 commits into
Conversation
Contributor
|
please update year in copyright header in modified files |
Contributor
Author
fixed it this e2db055 |
VPG-SWE-Github
pushed a commit
that referenced
this pull request
May 11, 2026
Replace std::string::find/rfind/find_last_of(c) with the char overload
find/rfind/find_last_of('c') throughout the codebase. The string-literal
overload constructs a temporary std::string_view/string and scans for a
null terminator; the char overload skips both steps. Replace the one
strstr(s, c) call with strchr(s, 'c') for the same reason.
In Drm::discoverDevices, move the renderDeviceSuffix strlen and the
Os::pciDevicesDirectory length computation out of the inner loop body:
renderDeviceSuffix is now constexpr and its length is a constexpr
compile-time constant; pciDevicesDirectory length is computed once before
the loop via std::char_traits<char>::length.
#791
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
Contributor
|
covered within 756681d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.