feat: add data, statusCode, headers to error directive JSON schema#352
Open
Simone Moglianesi @make.com (SM0gMaker) wants to merge 1 commit into
Open
feat: add data, statusCode, headers to error directive JSON schema#352Simone Moglianesi @make.com (SM0gMaker) wants to merge 1 commit into
Simone Moglianesi @make.com (SM0gMaker) wants to merge 1 commit into
Conversation
Add the new error directive properties to the Monaco JSON Schema so they are no longer flagged as "Property is not allowed": - data: custom data to pass through the error handling path - statusCode: HTTP status code or custom status code (number) - headers: response headers to pass through the error handling path Added to both top-level error properties and per-status-code patternProperties (^[0-9][0-9][0-9]$). Ref: IEN-15364
Simone Moglianesi @make.com (SM0gMaker)
requested a review
from a team
as a code owner
Generated |
Copilot started reviewing on behalf of
Simone Moglianesi @make.com (SM0gMaker)
May 19, 2026 22:11
View session
There was a problem hiding this comment.
Pull request overview
Updates the IML Monaco JSON schema for the #error directive to accept additional fields used by error handling, aligning the VS Code extension validation behavior with other SDKs/modules.
Changes:
- Allow
data,statusCode, andheaderson the top-level#errordirective object. - Allow
data,statusCode, andheadersinside status-code-specific overrides (^[0-9]{3}$) within#error.
Comments suppressed due to low confidence (2)
syntaxes/imljson/schemas/response.json:103
- Same as the top-level
statusCode:type: ["number", "string"]permits non-integer/out-of-range status codes. For consistency withdefinitions.respond.properties.status, consider usingoneOfwith an integer 100–999 or a string expression here too.
"statusCode": {
"description": "HTTP status code or custom status code.",
"type": ["number", "string"]
},
syntaxes/imljson/schemas/response.json:106
- Same as the top-level
headers: this is currently an unconstrained schema, while other schema locations usesources.json#/definitions/headersto validate header objects. Consider using the shared$refhere so status-code-specific overrides validate the same way.
"headers": {
"description": "Response headers to pass through the error handling path."
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IEN-15364
https://make.atlassian.net/browse/IEN-15364
Description
Updates the Monaco JSON schema (
response.json) to allowdata,statusCode, andheadersproperties in the#errordirective — both at the top level and within status-code-specific overrides (^[0-9]{3}$). Mirrors the same schema change applied toimt-web-zone. Resolves "Property is not allowed" validation errors in the VS Code extension for these new fields.Diamond
https://make.atlassian.net/wiki/spaces/RD/database/3064659981?contentId=3064659981&entryId=9fc99097-088a-4a5d-ac80-3f1ba12a5545&savedViewId=bb67ecdc-219a-4e3b-a753-8d9fc32be6b3