fix: improve github_organization_custom_properties resource#3234
Open
mkushakov wants to merge 2 commits intointegrations:mainfrom
Open
fix: improve github_organization_custom_properties resource#3234mkushakov wants to merge 2 commits intointegrations:mainfrom
mkushakov wants to merge 2 commits intointegrations:mainfrom
Conversation
- Remove broken CustomizeDiff referencing non-existent 'slug' field - Make 'property_name' ForceNew (renaming creates a new property, orphans old) - Make 'value_type' Required and ForceNew (can't create without type, changing type requires recreation) - Add allowed_values validation: required for select types, rejected for others - Add checkOrganization guard to all CRUD functions - Add graceful 404 handling in Read (removes from state instead of erroring) - Improve error messages with context - Fix Update double-read (Create already calls Read at the end) - Add resource Description - Use GetOk for optional fields to avoid sending zero values Resolves integrations#2806
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix several bugs and improve the
github_organization_custom_propertiesresource to handle edge cases correctly and align with GitHub API behavior.Resolves #2806
Changes
Bug Fixes
CustomizeDiff: The existingCustomizeDiffreferenced aslugfield that does not exist in the schema, causing unnecessary plan diffs. Removed entirely.GetOkfor optional fields: Changedallowed_valuesanddefault_valuereads to useGetOkinstead ofGetto correctly distinguish between unset and empty values.Improvements
ForceNewto immutable fields:property_nameandvalue_typecannot be changed on an existing custom property — they now force recreation.value_typeRequired: This field is required by the GitHub API and should not be optional.allowed_valuesvalidation:allowed_valuesis now required whenvalue_typeissingle_selectormulti_select, and rejected forstringandtrue_falsetypes viaCustomizeDiff.checkOrganizationguard: Create/Read/Update/Delete now validate that an organization is configured.fmt.Errorffor better context.Tests
allowed_valuesforstringtype.allowed_valuesforsingle_selecttype.Testing
go build ./...— passesgo vet ./...— passes