Skip to content

feat: Refactor secret values#3225

Draft
stevehipwell wants to merge 1 commit intointegrations:mainfrom
stevehipwell:refactor-secret-values
Draft

feat: Refactor secret values#3225
stevehipwell wants to merge 1 commit intointegrations:mainfrom
stevehipwell:refactor-secret-values

Conversation

@stevehipwell
Copy link
Collaborator

Resolves #ISSUE_NUMBER


Before the change?

  • Secret value naming was confusing
  • Encrypted secret value didn't require key_id to be passed in

After the change?

  • Secret value naming is consistent (value & value_encrypted)
  • Secret value names ready for value_wo pattern
  • value_encrypted requires key_id to be passed in

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@stevehipwell stevehipwell added this to the v6.12.0 Release milestone Feb 25, 2026
@stevehipwell stevehipwell self-assigned this Feb 25, 2026
@github-actions
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Copy link
Collaborator

@deiga deiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the migration test input state doesn't seem correct, could you verify?

@stevehipwell stevehipwell force-pushed the refactor-secret-values branch from 24bd7b8 to dcb06d3 Compare February 27, 2026 17:17
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@stevehipwell stevehipwell force-pushed the refactor-secret-values branch from dcb06d3 to e363fd4 Compare February 27, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants