refactor: unify deploy base path handling#2557
Open
joyenjoyer wants to merge 1 commit into
Open
Conversation
|
Visual regression report✅ No changes.
Baselines come from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is needed to be able to host PR previews on Github pages of
instructure-design-tokensrepo.Unify docs-app deploy base path handling
Make
PUBLIC_PATH(env var → webpackoutput.publicPath) the single source of truth for "where this build lives" and thread it through every layer:webpack.config.mjs— resolvePUBLIC_PATHonce and pass it to bothoutput.publicPathandHtmlWebpackPlugin'stemplateParameters.index.html—<base href>and the inline 404 SPA-redirect script both read the template parameter; the redirect is now generic instead of pattern-matchingpr-preview/latest.navigationUtils.ts— newgetDeployBase()reads__webpack_public_path__at runtime.parseCurrentUrlstrips it before parsing the in-app route;getAssetBasePathreturns it directly. RenamedprPrefix→basePrefixand de-duplicated a doubleparseCurrentUrl()call inbuildUrl.No behavior change for current
instructure.designdeploys. Unlocks hosting the docs-app at any base path — other repos (e.g. design-tokens previews) or arbitrary sub-hosts — by settingPUBLIC_PATHatbuild time.