Conversation
|
ToMESSKa
commented
May 6, 2026
| } | ||
|
|
||
| renderColumns() { | ||
| const { disabled } = this.props |
Contributor
Author
There was a problem hiding this comment.
Currently this fix:
- if a child has an explicit disabled={false} prop, it always gets overridden and the group always wins
- it is applied to every first-level child and not just InstUI components, so a
<div>some helper text</div>becomes<div disabled>some helper text</div>too - also I did not marked this as breaking change because looks more like a bug fix
If one of this is not supposed to be like that, let me know
HerrTopi
approved these changes
May 7, 2026
Contributor
HerrTopi
left a comment
HerrTopi
left a comment
There was a problem hiding this comment.
The description isn't disabled. Please check with design if it should be or not. If not, consider it approved if yes, please re-ask for my review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-4841
ISSUE:
TEST PLAN: