Skip to content

feat(ui-editable): rework InPlaceEdit#2483

Open
ToMESSKa wants to merge 1 commit intomasterfrom
INSTUI-4969-in-place-edit-rework-multi
Open

feat(ui-editable): rework InPlaceEdit#2483
ToMESSKa wants to merge 1 commit intomasterfrom
INSTUI-4969-in-place-edit-rework-multi

Conversation

@ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Mar 20, 2026

INSTUI-4969

ISSUE:

  • InPlaceEdit needs to be migrated to the new theming system
  • (Editable does not need to be migrated as it has no versioned import, tokens or icons)

TEST PLAN:

  • check if the component works the same as before in v1
  • check if the components and the examples work in v2 (especially the dark theme)
  • check if all necessary the imports are renamed to latest in v2
  • check if the test files are removed from the v1
  • check if the right imports are used in exports/b.ts and exports/a.ts
  • check if the package.json uses the correct versioning
  • check if the renamed or removed tokes are documented in the upgrade guide (if there are any)
  • check if the index.ts files use withStyle instead of withStyleLegacy
  • check if the v2 component uses all the tokens
  • check if all the old icons were replace with the new ones in the index.tsx, test and README files

see this link to see the rework:

@ToMESSKa ToMESSKa self-assigned this Mar 20, 2026
@github-actions
Copy link

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://instructure.design/pr-preview/pr-2483/

Built to branch gh-pages at 2026-03-20 14:52 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@ToMESSKa ToMESSKa requested review from git-nandor and matyasf March 20, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant