Conversation
|
matyasf
requested changes
Mar 19, 2026
Comment on lines
+36
to
+52
|
|
||
| ### BREAKING CHANGES | ||
|
|
||
| * **ui-text:** Removed 'alert' color prop value. Use 'primary' color instead. | ||
|
|
||
| Also improves documentation: | ||
| - Clarify variant usage and recommendations in README | ||
| - Add deprecation notes for size, weight, and lineHeight legacy values | ||
| - Update color examples to include inverse colors and remove alert | ||
| - Add JSDoc comments for deprecated prop values | ||
| - Improve code examples with clearer formatting | ||
|
|
||
| To test: Compare with Figma design | ||
|
|
||
| 🤖 Generated with [Claude Code](https://claude.com/claude-code) | ||
|
|
||
| Co-Authored-By: Claude <noreply@anthropic.com> |
Collaborator
There was a problem hiding this comment.
Why is it including these changes? Because it was manually removed? We should remove it now too
Comment on lines
+93
to
+113
| ### Reverts | ||
|
|
||
| * **ui-scripts:** revert last 6 commits ([be97efa](https://github.com/instructure/instructure-ui/commit/be97efa1673e9130e494b11654360d7272d908a0)) | ||
|
|
||
|
|
||
| ### BREAKING CHANGES | ||
|
|
||
| * **ui-text:** Removed 'alert' color prop value. Use 'primary' color instead. | ||
|
|
||
| Also improves documentation: | ||
| - Clarify variant usage and recommendations in README | ||
| - Add deprecation notes for size, weight, and lineHeight legacy values | ||
| - Update color examples to include inverse colors and remove alert | ||
| - Add JSDoc comments for deprecated prop values | ||
| - Improve code examples with clearer formatting | ||
|
|
||
| To test: Compare with Figma design | ||
|
|
||
| 🤖 Generated with [Claude Code](https://claude.com/claude-code) | ||
|
|
||
| Co-Authored-By: Claude <noreply@anthropic.com> |
Collaborator
There was a problem hiding this comment.
lets remove the noise from here
Comment on lines
+27
to
+29
| ### Reverts | ||
|
|
||
| * **ui-scripts:** revert last 6 commits ([be97efa](https://github.com/instructure/instructure-ui/commit/be97efa1673e9130e494b11654360d7272d908a0)) |
balzss
approved these changes
Mar 20, 2026
Contributor
balzss
left a comment
balzss
left a comment
There was a problem hiding this comment.
i agree with the changelog cleanup, otherwise it's ok
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.