Skip to content

fix(ui-buttons): fix button to icon size mapping #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balzss merged 1 commit into from
Mar 19, 2026
Merged

fix(ui-buttons): fix button to icon size mapping #2477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/ui-buttons/src/BaseButton/v2/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,16 +52,16 @@ const buttonSizeToIconSize = {
small: 'sm',
medium: 'md',
large: 'lg',
condensedSmall: 'xs',
condensedMedium: 'xs'
condensedSmall: 'sm',
condensedMedium: 'md'
} as const

const buttonColorToIconColor = {
'primary': 'inherit',
primary: 'inherit',
'primary-inverse': 'inherit',
'secondary': 'inherit',
'success': 'inherit',
'danger': 'inherit',
secondary: 'inherit',
success: 'inherit',
danger: 'inherit',
'ai-primary': 'inherit',
'ai-secondary': 'ai'
} as const
Expand Down
4 changes: 2 additions & 2 deletions packages/ui-buttons/src/Button/v2/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,14 +195,14 @@ type: example

### Rendering Buttons without backgrounds

Use backgroundless buttons when there is a need to deemphasize the button. Be sure to use border/text colors that meet the proper contrast ratios with whatever background they are placed on.
Use backgroundless buttons when there is a need to deemphasize the button. Be sure to use border/text colors that meet the proper contrast ratios with whatever background they are placed on. Backgroundless buttons are sometimes called `tertiary` variant.

```js
---
type: example
---
<View display="block">
<Button renderIcon={PlusInstUIIcon} withBackground={false} color="secondary" margin="small">Click here</Button>
<Button renderIcon={PlusInstUIIcon} withBackground={false} color="primary" margin="small">Click here</Button>
</View>
```

Expand Down
Loading