Skip to content

fix(many): fix checkbox icons and fix border bugs in menu and in dateInput #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
git-nandor merged 1 commit into from
Mar 23, 2026
+6 −5
Merged

fix(many): fix checkbox icons and fix border bugs in menu and in dateInput #2473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/ui-calendar/src/Calendar/v2/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@ class Calendar extends Component<CalendarProps, CalendarState> {
display="inline-block"
padding="small"
background="primary"
borderRadius="inherit"
elementRef={this.handleRef}
data-cid="Calendar"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/ui-checkbox/src/Checkbox/v2/ToggleFacade/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ const generateStyle = (
border: `${componentTheme.borderWidth} solid ${getIconBorderColor()}`
},

'& [class*="lucideIcon"] svg': {
'& [class*="icon"] svg': {
position: 'relative',
zIndex: 1
}
Expand Down
3 changes: 2 additions & 1 deletion packages/ui-dialog/src/Dialog/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,8 @@ class Dialog extends Component<DialogProps> {
{...omitProps(this.props, Dialog.allowedProps)}
role={role}
aria-label={this.props.label}
className={this.props.className}
className={this.props.className} // TODO in V2 remove className, there is no usage of it.
style={{ borderRadius: 'inherit' }} // ensure the dialog inherits border radius from View
ref={this.getRef}
>
{this.props.children}
Expand Down
2 changes: 1 addition & 1 deletion packages/ui-menu/src/Menu/v2/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const generateStyle = (
padding: '0.25rem 0',
// TODO-rework
//background: componentTheme.background,
Copy link
Contributor

@balzss balzss Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated to the pr but i'm not sure why this is commented out

Copy link
Contributor Author

@git-nandor git-nandor Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll double check it with designer

Copy link
Contributor

@balzss balzss Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there is no straightworfard answer, let's leave it for now since it's out of the scope of this task anyway

//borderRadius: componentTheme.borderRadius,
borderRadius: 'inherit',
display: 'block',
position: 'relative',
overflow: 'hidden',
Expand Down
3 changes: 1 addition & 2 deletions packages/ui-view/src/ContextView/v2/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,8 +307,7 @@ const generateStyle = (
},
contextView__content: {
label: 'contextView__content',
position: 'relative',
overflow: 'clip',
position: 'relative'
},
contextView__arrow: {
label: 'contextView__arrow',
Expand Down
Loading