Open
Conversation
now bootstrap builds the new theme tokens
…docs - child components are not working yet - Add a utility function to convert box shadow objects to strings - Update theme type generator script to make it possible to customize types INSTUI-4707
it uses now types from Token Studio
…edTokens to generateStyles INSTUI-4846
remove require path, because it was used to import from the deprecated 'canvas-theme', 'canvar-high-contrast-theme' packages remove functional theme support, it was used only for Avatar useStyle no longer needs generateComponentTheme since this is not used by new themes
The tests are failing because icons are not working yet
Also update its readme with a more comprehensive example delete old theme.ts INSTUI-4804
…d of withDeterministicId for functional components
Migrates Text component from legacy theme.ts to new token-based theming system: - Remove theme.ts file and use direct token references in styles - Update color mappings to use new semantic tokens (baseColor, mutedColor, etc.) - Add fontFamily to variant definitions from typography tokens - Update theme variable references throughout styles.ts BREAKING CHANGE: Removed 'alert' color prop value. Use 'primary' color instead. Also improves documentation: - Clarify variant usage and recommendations in README - Add deprecation notes for size, weight, and lineHeight legacy values - Update color examples to include inverse colors and remove alert - Add JSDoc comments for deprecated prop values - Improve code examples with clearer formatting To test: Compare with Figma design 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The issue was that wrapLucudeIcon/styles.ts uses px() which uses getFontSize() which uses document.documentElement.style.fontSize to determine font size, but this is "" by default in jest-dom, resulting in NaN icon sizes
GitHub Pages only supports a single 404.html at the repo root. Deep links under subdirectory deployments (/pr-preview/pr-N/ and /latest/) would serve the root 404.html which loaded the wrong app bundle. Changes: - Add redirect script in index.html that detects PR preview and /latest/ sub-routes and redirects to the subdirectory root with the route encoded as a query parameter (__spa_route) - Restore the original clean URL via history.replaceState on app load - Add <base href="/"> so relative paths in 404.html resolve from root - Support PUBLIC_PATH env var in webpack config for subdirectory builds - Set PUBLIC_PATH=/latest/ for the deploy-latest workflow job - Add /latest/ as a recognized URL prefix in navigationUtils
getPathInfo() has its own URL parsing separate from navigationUtils' parseCurrentUrl(). It was missing the /latest/ prefix skip, causing /latest/v11_7/Menu to be parsed as page="latest" instead of page="Menu".
…d docs The version map stored a single componentVersion per package per library version, determined by the first import found in the export file. This excluded components that haven't been migrated to v2 (e.g. DateInput2) from v11_7 docs, because the export file also imports DateInput/v2 and only that first match was recorded. Changed to collect all component versions referenced in each export file so packages with mixed v1/v2 components are correctly included.
|
… simplify TextInput afterElement Add condensedSmall and condensedMedium size options to IconButton, matching Button's existing condensed size support. These are intended for use inside compact layouts like TextInput. Remove temporary workarounds from TextInput that were needed to make the old IconButton work inside the afterElement slot: - Remove adjustAfterElementHeight DOM hack - Remove sizeVariants spread on afterElement container - Remove afterElementHasWidth state machinery - Simplify afterElement to a basic flex container with padding Update documentation examples in both IconButton and TextInput READMEs with a password visibility toggle use case and current icon names.
…s inheritance issues in DateInput and Menu from View
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should compare the state of the repo to the current master. Do not merge!!!