feat(ui-options,ui-select,ui-simple-select,ui-time-select): rework Select, SimpleSelect and TimeSelect#2465
Open
feat(ui-options,ui-select,ui-simple-select,ui-time-select): rework Select, SimpleSelect and TimeSelect#2465
Conversation
ToMESSKa
commented
Mar 17, 2026
Comment on lines
73
to
+74
| background: componentTheme.selectedHighlightedBackground, | ||
| color: componentTheme.highlightedLabelColor | ||
| color: componentTheme.selectedLabelColor |
Contributor
Author
There was a problem hiding this comment.
This worked in the two old canvas themes, but in the new light theme, the label would be black on a dark background (bad visibility) and in the new dark theme it would be white on a white background (bad visibilty). So I changed this. You can check this on the first example of in Select.
|
ToMESSKa
force-pushed
the
INSTUI-4807-select-rework-multi
branch
from
1e24d97 to
7f09718
Compare
…lect, SimpleSelect and TimeSelect INSTUI-4807
ToMESSKa
force-pushed
the
INSTUI-4807-select-rework-multi
branch
from
878d061 to
21862c2
Compare
ToMESSKa
changed the title
balzss
requested changes
Mar 20, 2026
Contributor
balzss
left a comment
balzss
left a comment
There was a problem hiding this comment.
2 smaller things that i've noticed:
- with the new
lighttheme, the select looks a bit too dark, i've already pinged @hajnaldo about this, she will look into this - the SimpleSelect
Controlledexample features a scrollbar and the corners doesn't follow the border radius correctly. this might be the same issue as #2473 or very similar. can you please rebase once it's merged to see if that solves it and if it isn't, try to maybe adopt that solution for the select?
matyasf
requested changes
Mar 20, 2026
Collaborator
matyasf
left a comment
matyasf
left a comment
There was a problem hiding this comment.
Just a couple of import issues
|
|
||
| import { InputHTMLAttributes } from 'react' | ||
|
|
||
| import type { FormMessage } from '@instructure/ui-form-field/v11_6' |
Collaborator
There was a problem hiding this comment.
I think this needs to be /latest
|
|
||
| import { InputHTMLAttributes } from 'react' | ||
|
|
||
| import type { FormMessage } from '@instructure/ui-form-field/v11_6' |
Collaborator
There was a problem hiding this comment.
I think this needs to be /latest
| PositionConstraint, | ||
| PositionMountNode | ||
| } from '@instructure/ui-position' | ||
| import type { SelectOwnProps } from '@instructure/ui-select/v11_6' |
Collaborator
There was a problem hiding this comment.
I think this needs to be /latest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-4807
ISSUE:
TEST PLAN:
for Select, SimpleSelect, TimeSelect:
exports/b.tsandexports/a.tspackage.jsonuses the correct versioning