Skip to content

Use the model path from the positional model name #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vishnoianil merged 1 commit into from
Apr 8, 2025
Merged

Use the model path from the positional model name #714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions api-server/vllm-serve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ func (srv *ILabServer) ListVllmContainers() ([]VllmContainer, error) {
format := "{{.ID}}|{{.Image}}|{{.Command}}|{{.CreatedAt}}|{{.Status}}|{{.Ports}}|{{.Names}}"

cmd := exec.Command("podman", "ps",
"--filter", "ancestor=registry.redhat.io/rhelai1/instructlab-nvidia-rhel9",
"--filter", "ancestor=registry.redhat.io/rhelai1/instructlab-nvidia-rhel9:1.4-1738905416",
"--format", format,
)

Expand Down Expand Up @@ -102,7 +102,8 @@ func (srv *ILabServer) ExtractVllmArgs(containerID string) (string, string, erro
containerID, err, inspectErr.String())
}

// The command is a JSON array, e.g. ["--host","0.0.0.0","--port","8000","--model","/path","--served-model-name","pre-train"]
// The command is a JSON array, e.g.:
// ["serve","/var/home/cloud-user/.cache/instructlab/models/granite-8b-starter-v1","--served-model-name","pre-train","--load-format","safetensors","--host","127.0.0.1","--port","8000"]
var cmdArgs []string
if err := json.Unmarshal(inspectOut.Bytes(), &cmdArgs); err != nil {
return "", "", fmt.Errorf("error unmarshalling command args for container %s: %v",
Expand Down Expand Up @@ -138,6 +139,13 @@ func (srv *ILabServer) parseVllmArgs(args []string) (string, string, error) {
}
}
}

// If modelPath wasn't set via the flag, check for a positional model path.
// If the command starts with "serve" and a second argument exists, use that as the model path.
if modelPath == "" && len(args) > 1 && args[0] == "serve" {
modelPath = args[1]
}

if servedModelName == "" || modelPath == "" {
return "", "", errors.New("required arguments --served-model-name or --model not found")
}
Expand Down
Loading