Skip to content

Conversation

@courtneypacheco
Copy link
Contributor

@courtneypacheco courtneypacheco commented May 15, 2025

Overview

In our core repo, we require Python >=3.11: https://github.com/instructlab/instructlab/blob/main/pyproject.toml#L13

In this repo, however, we currently require Python >=3.9, and we are only testing against Python 3.10 and 3.11 in the CI. Therefore, we should ensure consistency in terms of Python version support throughout our GitHub org.

Proposed Changes

This bump includes updates to documentation, Git workflows, test configs, etc.

This bump includes updates to documentation, Git workflows, test configs, etc.

Signed-off-by: Courtney Pacheco <6019922+courtneypacheco@users.noreply.github.com>
@mergify mergify bot added CI/CD Affects CI/CD configuration documentation Improvements or additions to documentation testing Relates to testing labels May 15, 2025
fail-fast: false
matrix:
python:
- "3.10"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: We ultimately want to add Python 3.12 support, which is why I want to leave the matrix logic as is despite us only testing with 3.11 right now.

@courtneypacheco courtneypacheco marked this pull request as ready for review May 15, 2025 11:58
@courtneypacheco courtneypacheco requested review from a team and RobotSail May 15, 2025 11:59
@mergify mergify bot added the one-approval label May 15, 2025
@mergify mergify bot added the ci-failure label May 15, 2025
@booxter
Copy link
Contributor

booxter commented May 20, 2025

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented May 20, 2025

rebase

❌ Command disallowed due to command restrictions in the Mergify configuration.

Details
  • any of:
    • sender = {{author}}
    • sender-permission >= write

@RobotSail RobotSail merged commit e57265b into main May 20, 2025
16 of 18 checks passed
@ktdreyer ktdreyer deleted the remove-python-3.9-and-3.10-support branch June 5, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Affects CI/CD configuration ci-failure documentation Improvements or additions to documentation one-approval testing Relates to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants