Skip to content

fix: updated amqp instrumentation, adapted attributes and unittests#738

Merged
CagriYonca merged 1 commit into
mainfrom
fix/aioamqp
Jun 17, 2025
Merged

fix: updated amqp instrumentation, adapted attributes and unittests#738
CagriYonca merged 1 commit into
mainfrom
fix/aioamqp

Conversation

@CagriYonca
Copy link
Copy Markdown
Contributor

  • Updated aioamqp instrumentation, changed spantype from sdk to amqp.
  • Adapted attributes according to the backend code.

@CagriYonca CagriYonca self-assigned this May 21, 2025
@CagriYonca CagriYonca requested a review from a team as a code owner May 21, 2025 09:46
@CagriYonca CagriYonca force-pushed the fix/aioamqp branch 2 times, most recently from 6eaddf5 to 0c61b0f Compare May 21, 2025 10:28
Copy link
Copy Markdown
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments.

Comment thread src/instana/instrumentation/aioamqp.py Outdated
Comment thread src/instana/instrumentation/aioamqp.py Outdated
Comment thread tests/frameworks/test_aioamqp.py
Comment thread src/instana/instrumentation/aioamqp.py Outdated
@CagriYonca CagriYonca force-pushed the fix/aioamqp branch 2 times, most recently from 0340981 to 804aef3 Compare June 10, 2025 14:10
Copy link
Copy Markdown
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question!

Comment thread tests/requirements.txt Outdated
Copy link
Copy Markdown
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@CagriYonca CagriYonca merged commit df5f489 into main Jun 17, 2025
16 checks passed
@CagriYonca CagriYonca deleted the fix/aioamqp branch June 17, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants