Skip to content

fix: change request url for urllib #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GSVarsha merged 1 commit into from
May 5, 2025
Merged

fix: change request url for urllib #725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tests/clients/test_urllib3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def make_request(u=None) -> int:

threadpool_size = 15
pool = ThreadPool(processes=threadpool_size)
res = pool.map(make_request, [u for u in range(threadpool_size)])
_ = pool.map(make_request, [u for u in range(threadpool_size)])
# print(f'requests made within threadpool, instana does not instrument - statuses: {res}')

spans = self.recorder.queued_spans()
Expand Down Expand Up @@ -137,7 +137,7 @@ def test_get_request(self):
assert len(urllib3_span.stack) > 1

def test_get_request_https(self):
request_url = "https://reqres.in:443/api/users"
request_url = "https://jsonplaceholder.typicode.com:443/todos/1"
with tracer.start_as_current_span("test"):
r = self.http.request("GET", request_url)

Expand Down Expand Up @@ -631,7 +631,9 @@ def test_exception_logging(self):
assert test_span.data["sdk"]["name"] == "test"
assert urllib3_span.n == "urllib3"
assert urllib3_span.data["http"]["status"] == 500
assert urllib3_span.data["http"]["url"] == testenv["flask_server"] + "/exception"
assert (
urllib3_span.data["http"]["url"] == testenv["flask_server"] + "/exception"
)
assert urllib3_span.data["http"]["method"] == "GET"
assert urllib3_span.stack
assert isinstance(urllib3_span.stack, list)
Expand Down
Loading