feat: added support for v26#2524
Conversation
|
Currently the prebuilds are not working: This seems to be due to NAN (Native Abstractions for Node.js) not supporting Node.js v26 yet. See: https://github.com/nodejs/nan#native-abstractions-for-nodejs The current NAN version 2.26.2 only supports Node.js up to version 25. Node.js v26 introduced breaking changes in the V8 API that are incompatible with NAN. The gc-stats also filing on npm install step, because of the nan. I've created an issue here nodejs/nan#1017 |
| "nan": "2.27.0" | ||
| }, | ||
| "mocha": { | ||
| "yargs": "18.0.0" |
There was a problem hiding this comment.
Yargs v18 currently not compatible with Node.js v18, we skip v18 build for now, until yargs resolves the compatibility issue.
| "moment": "2.30.1", | ||
| "morgan": "1.10.0", | ||
| "nan": "2.22.2", | ||
| "nan": "2.27.0", |
There was a problem hiding this comment.
nan v2.27.0 added support for v26
| { | ||
| "v": "7.8.0", | ||
| "node": ">=20.19.0 <23 || >=24", | ||
| "node": ">=20.19.0 <23 || >=24 <26", |
There was a problem hiding this comment.
Prisma currently failing for v26, skipped for now. card: https://jsw.ibm.com/browse/INSTA-89970
There was a problem hiding this comment.
Cool. Moved to blocked. Are they aware already?
There was a problem hiding this comment.
No I will create a git issue later
|
Really great work <3 As discussed, we will try mocha-v18 to run the v18 tests in a separate PR |
abhilash-sivan
left a comment
abhilash-sivan
left a comment
There was a problem hiding this comment.
LGTM. We should run the ESM pipelines too before merging
|
3 participants
Tasks
ref https://jsw.ibm.com/browse/INSTA-80071
Issues
Node.js comes with V8 14.6 and some breaking changes. There are open issues to support Node.js on Nan and yargs:
Let's wait for the v26 fixes