Adding Jnj templates scripts

[munoztd0]

As discussed we want to integrate JnJ innovative medecine newly release open-source TLG catalog scripts.

Any feedback would be very welcomed.

[github-actions]

Unit Tests Summary

  1 files  274 suites   24m 2s ⏱️
411 tests 219 ✅ 186 💤 0 ❌ 6 🔥
676 runs  267 ✅ 403 💤 0 ❌ 6 🔥

For more details on these errors, see this check.

Results for commit 6b7ec8a.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test suite performance difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
lsfae01	👶		$+1.28$	$+1$	$+1$	$0$	$0$
lsfae02	👶		$+1.13$	$+1$	$+1$	$0$	$0$
lsfae03	👶		$+0.75$	$+1$	$+1$	$0$	$0$
lsfae04	👶		$+0.31$	$+1$	$+1$	$0$	$0$
lsfae05	👶		$+1.47$	$+1$	$+1$	$0$	$0$
lsfae06a	👶		$+0.98$	$+1$	$+1$	$0$	$0$
lsfae06b	👶		$+0.95$	$+1$	$+1$	$0$	$0$
lsfdth01	👶		$+0.29$	$+1$	$+1$	$0$	$0$
lsfecg01	👶		$+1.10$	$+1$	$+1$	$0$	$0$
lsfecg02part1	👶		$+22.56$	$+1$	$+1$	$0$	$0$
lsfecg02part2	👶		$+22.53$	$+1$	$+1$	$0$	$0$
lsfecg02part3	👶		$+22.14$	$+1$	$+1$	$0$	$0$
lsflab01	👶		$+1.07$	$+1$	$+1$	$0$	$0$
lsfvit01	👶		$+1.89$	$+1$	$+1$	$0$	$0$
lsfvit02	👶		$+433.64$	$+1$	$+1$	$0$	$0$
lsicm01	👶		$+1.07$	$+1$	$+1$	$0$	$0$
lsidem01	👶		$+0.86$	$+1$	$+1$	$0$	$0$
lsidem02	👶		$+0.77$	$+1$	$+1$	$0$	$0$
lsids01	👶		$+0.81$	$+1$	$+1$	$0$	$0$
lsids02	👶		$+0.84$	$+1$	$+1$	$0$	$0$
lsids03	👶		$+0.84$	$+1$	$+1$	$0$	$0$
lsids04	👶		$+0.19$	$+1$	$+1$	$0$	$0$
lsids05	👶		$+0.14$	$+1$	$+1$	$0$	$0$
lsiex01	👶		$+0.95$	$+1$	$+1$	$0$	$0$
lsiex02	👶		$+0.63$	$+1$	$+1$	$0$	$0$
lsiex03	👶		$+1.20$	$+1$	$+1$	$0$	$0$
lsimh01	👶		$+0.89$	$+1$	$+1$	$0$	$0$
table_aet02	💔	$8.44$	$+1.08$	$0$	$+12$	$0$	$0$
table_lbt14	💔	$32.67$	$+2.54$	$0$	$+5$	$0$	$0$
table_lgrt02	💔	$2.83$	$+1.49$	$0$	$+4$	$0$	$0$
table_ttet01	💔	$3.41$	$+1.03$	$0$	$+7$	$0$	$0$
tpk01a	👶		$+4.03$	$+1$	$+1$	$0$	$0$
tpk01bpart1	👶		$+3.61$	$+1$	$0$	$0$	$+1$
tpk01bpart2	👶		$+3.71$	$+1$	$0$	$0$	$+1$
tpk02part1	👶		$+9.24$	$+1$	$0$	$0$	$+1$
tpk02part2	👶		$+9.52$	$+1$	$0$	$0$	$+1$
tpk03	👶		$+2.83$	$+1$	$+1$	$0$	$0$
tsfae01a	👶		$+2.48$	$+1$	$+1$	$0$	$0$
tsfae01b	👶		$+1.89$	$+1$	$+1$	$0$	$0$
tsfae02	👶		$+3.41$	$+1$	$+1$	$0$	$0$
tsfae02a	👶		$+9.71$	$+1$	$+1$	$0$	$0$
tsfae03	👶		$+3.58$	$+1$	$+1$	$0$	$0$
tsfae03a	👶		$+8.93$	$+1$	$+1$	$0$	$0$
tsfae04	👶		$+2.94$	$+1$	$+1$	$0$	$0$
tsfae04a	👶		$+6.41$	$+1$	$+1$	$0$	$0$
tsfae05	👶		$+3.08$	$+1$	$+1$	$0$	$0$
tsfae05a	👶		$+5.08$	$+1$	$+1$	$0$	$0$
tsfae06a	👶		$+5.80$	$+1$	$+1$	$0$	$0$
tsfae06b	👶		$+18.58$	$+1$	$+1$	$0$	$0$
tsfae07a	👶		$+2.69$	$+1$	$+1$	$0$	$0$
tsfae07b	👶		$+2.74$	$+1$	$+1$	$0$	$0$
tsfae08	👶		$+3.20$	$+1$	$+1$	$0$	$0$
tsfae09	👶		$+1.01$	$+1$	$+1$	$0$	$0$
tsfae10	👶		$+5.22$	$+1$	$+1$	$0$	$0$
tsfae11	👶		$+2.96$	$+1$	$+1$	$0$	$0$
tsfae12	👶		$+3.14$	$+1$	$+1$	$0$	$0$
tsfae13	👶		$+1.47$	$+1$	$0$	$0$	$+1$
tsfae14	👶		$+5.15$	$+1$	$+1$	$0$	$0$
tsfae15	👶		$+2.95$	$+1$	$+1$	$0$	$0$
tsfae16part1	👶		$+11.90$	$+1$	$+1$	$0$	$0$
tsfae16part2	👶		$+11.75$	$+1$	$+1$	$0$	$0$
tsfae17a	👶		$+3.62$	$+1$	$+1$	$0$	$0$
tsfae17b	👶		$+2.58$	$+1$	$+1$	$0$	$0$
tsfae17c	👶		$+4.16$	$+1$	$+1$	$0$	$0$
tsfae17d	👶		$+3.95$	$+1$	$+1$	$0$	$0$
tsfae19a	👶		$+0.76$	$+1$	$+1$	$0$	$0$
tsfae19b	👶		$+0.73$	$+1$	$+1$	$0$	$0$
tsfae19c	👶		$+1.19$	$+1$	$+1$	$0$	$0$
tsfae19d	👶		$+1.14$	$+1$	$+1$	$0$	$0$
tsfae20a	👶		$+1.55$	$+1$	$+1$	$0$	$0$
tsfae20b	👶		$+1.57$	$+1$	$+1$	$0$	$0$
tsfae20c	👶		$+1.57$	$+1$	$+1$	$0$	$0$
tsfae21apart1	👶		$+9.28$	$+1$	$+1$	$0$	$0$
tsfae21apart2	👶		$+8.68$	$+1$	$+1$	$0$	$0$
tsfae21apart3	👶		$+8.75$	$+1$	$+1$	$0$	$0$
tsfae21apart4	👶		$+8.90$	$+1$	$+1$	$0$	$0$
tsfae21bpart1	👶		$+12.01$	$+1$	$+1$	$0$	$0$
tsfae21bpart2	👶		$+11.46$	$+1$	$+1$	$0$	$0$
tsfae21bpart3	👶		$+11.65$	$+1$	$+1$	$0$	$0$
tsfae21bpart4	👶		$+12.06$	$+1$	$+1$	$0$	$0$
tsfae21c	👶		$+6.64$	$+1$	$+1$	$0$	$0$
tsfae21d	👶		$+8.79$	$+1$	$+1$	$0$	$0$
tsfae22apart1	👶		$+10.50$	$+1$	$+1$	$0$	$0$
tsfae22apart2	👶		$+10.77$	$+1$	$+1$	$0$	$0$
tsfae22apart3	👶		$+10.03$	$+1$	$+1$	$0$	$0$
tsfae22apart4	👶		$+10.17$	$+1$	$+1$	$0$	$0$
tsfae22bpart1	👶		$+6.47$	$+1$	$+1$	$0$	$0$
tsfae22bpart2	👶		$+6.82$	$+1$	$+1$	$0$	$0$
tsfae22cpart1	👶		$+8.78$	$+1$	$+1$	$0$	$0$
tsfae22cpart2	👶		$+8.99$	$+1$	$+1$	$0$	$0$
tsfae22cpart3	👶		$+9.04$	$+1$	$+1$	$0$	$0$
tsfae22cpart4	👶		$+9.58$	$+1$	$+1$	$0$	$0$
tsfae23a	👶		$+0.96$	$+1$	$+1$	$0$	$0$
tsfae23b	👶		$+0.42$	$+1$	$+1$	$0$	$0$
tsfae23c	👶		$+0.72$	$+1$	$+1$	$0$	$0$
tsfae23d	👶		$+0.96$	$+1$	$+1$	$0$	$0$
tsfae24a	👶		$+0.52$	$+1$	$+1$	$0$	$0$
tsfae24b	👶		$+0.57$	$+1$	$+1$	$0$	$0$
tsfae24c	👶		$+2.88$	$+1$	$+1$	$0$	$0$
tsfae24d	👶		$+3.04$	$+1$	$+1$	$0$	$0$
tsfae24fpart1	👶		$+12.54$	$+1$	$+1$	$0$	$0$
tsfae24fpart2	👶		$+13.06$	$+1$	$+1$	$0$	$0$
tsfae24fpart3	👶		$+12.32$	$+1$	$+1$	$0$	$0$
tsfdth01	👶		$+1.38$	$+1$	$+1$	$0$	$0$
tsfecg01apart1	👶		$+4.91$	$+1$	$+1$	$0$	$0$
tsfecg01apart2	👶		$+4.99$	$+1$	$+1$	$0$	$0$
tsfecg01apart3	👶		$+5.00$	$+1$	$+1$	$0$	$0$
tsfecg01part1	👶		$+10.19$	$+1$	$+1$	$0$	$0$
tsfecg01part2	👶		$+9.34$	$+1$	$+1$	$0$	$0$
tsfecg02	👶		$+3.47$	$+1$	$+1$	$0$	$0$
tsfecg03	👶		$+0.64$	$+1$	$+1$	$0$	$0$
tsfecg04	👶		$+2.36$	$+1$	$+1$	$0$	$0$
tsfecg05	👶		$+1.48$	$+1$	$+1$	$0$	$0$
tsflab01apart1	👶		$+16.06$	$+1$	$+1$	$0$	$0$
tsflab01apart2	👶		$+14.69$	$+1$	$+1$	$0$	$0$
tsflab01apart3	👶		$+15.12$	$+1$	$+1$	$0$	$0$
tsflab01part1	👶		$+6.67$	$+1$	$+1$	$0$	$0$
tsflab01part2	👶		$+6.09$	$+1$	$+1$	$0$	$0$
tsflab02	👶		$+1.11$	$+1$	$+1$	$0$	$0$
tsflab02a	👶		$+2.95$	$+1$	$+1$	$0$	$0$
tsflab02b	👶		$+2.48$	$+1$	$+1$	$0$	$0$
tsflab03	👶		$+3.78$	$+1$	$+1$	$0$	$0$
tsflab03a	👶		$+0.03$	$+1$	$0$	$0$	$+1$
tsflab04a	👶		$+3.01$	$+1$	$+1$	$0$	$0$
tsflab04b	👶		$+1.30$	$+1$	$+1$	$0$	$0$
tsflab05	👶		$+3.47$	$+1$	$+1$	$0$	$0$
tsflab06	👶		$+3.71$	$+1$	$+1$	$0$	$0$
tsflab07	👶		$+19.34$	$+1$	$+1$	$0$	$0$
tsfvit01apart1	👶		$+7.51$	$+1$	$+1$	$0$	$0$
tsfvit01apart2	👶		$+7.90$	$+1$	$+1$	$0$	$0$
tsfvit01apart3	👶		$+6.89$	$+1$	$+1$	$0$	$0$
tsfvit01apart4	👶		$+7.00$	$+1$	$+1$	$0$	$0$
tsfvit01part1	👶		$+3.50$	$+1$	$+1$	$0$	$0$
tsfvit01part2	👶		$+3.53$	$+1$	$+1$	$0$	$0$
tsfvit01part3	👶		$+3.60$	$+1$	$+1$	$0$	$0$
tsfvit01part4	👶		$+3.60$	$+1$	$+1$	$0$	$0$
tsfvit02	👶		$+0.78$	$+1$	$+1$	$0$	$0$
tsfvit03	👶		$+0.78$	$+1$	$+1$	$0$	$0$
tsfvit04	👶		$+0.76$	$+1$	$+1$	$0$	$0$
tsfvit05	👶		$+2.15$	$+1$	$+1$	$0$	$0$
tsfvit06	👶		$+0.71$	$+1$	$+1$	$0$	$0$
tsicm01	👶		$+6.50$	$+1$	$+1$	$0$	$0$
tsicm02	👶		$+6.05$	$+1$	$+1$	$0$	$0$
tsicm03	👶		$+4.32$	$+1$	$+1$	$0$	$0$
tsicm04	👶		$+4.33$	$+1$	$+1$	$0$	$0$
tsicm05	👶		$+8.04$	$+1$	$+1$	$0$	$0$
tsicm06	👶		$+8.18$	$+1$	$+1$	$0$	$0$
tsicm07	👶		$+1.22$	$+1$	$+1$	$0$	$0$
tsicm08	👶		$+0.73$	$+1$	$+1$	$0$	$0$
tsidem01	👶		$+2.59$	$+1$	$+1$	$0$	$0$
tsidem02	👶		$+0.85$	$+1$	$+1$	$0$	$0$
tsids01	👶		$+0.43$	$+1$	$+1$	$0$	$0$
tsids02	👶		$+1.70$	$+1$	$+1$	$0$	$0$
tsids02a	👶		$+8.59$	$+1$	$+1$	$0$	$0$
tsiex01	👶		$+1.70$	$+1$	$+1$	$0$	$0$
tsiex02	👶		$+1.51$	$+1$	$+1$	$0$	$0$
tsiex03	👶		$+1.20$	$+1$	$+1$	$0$	$0$
tsiex04	👶		$+1.04$	$+1$	$+1$	$0$	$0$
tsiex06	👶		$+0.48$	$+1$	$+1$	$0$	$0$
tsiex07	👶		$+0.73$	$+1$	$+1$	$0$	$0$
tsiex08	👶		$+1.51$	$+1$	$+1$	$0$	$0$
tsiex09	👶		$+0.71$	$+1$	$+1$	$0$	$0$
tsiex10	👶		$+0.75$	$+1$	$+1$	$0$	$0$
tsiex11	👶		$+3.48$	$+1$	$+1$	$0$	$0$
tsimh01	👶		$+1.32$	$+1$	$+1$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
lsfae01	👶		$+1.28$	lsfae01
lsfae02	👶		$+1.13$	lsfae02
lsfae03	👶		$+0.75$	lsfae03
lsfae04	👶		$+0.31$	lsfae04
lsfae05	👶		$+1.47$	lsfae05
lsfae06a	👶		$+0.98$	lsfae06a
lsfae06b	👶		$+0.95$	lsfae06b
lsfdth01	👶		$+0.29$	lsfdth01
lsfecg01	👶		$+1.10$	lsfecg01
lsfecg02part1	👶		$+22.56$	lsfecg02part1of3
lsfecg02part2	👶		$+22.53$	lsfecg02part2of3
lsfecg02part3	👶		$+22.14$	lsfecg02part3of3
lsflab01	👶		$+1.07$	lsflab01
lsfvit01	👶		$+1.89$	lsfvit01
lsfvit02	👶		$+433.64$	lsfvit02
lsicm01	👶		$+1.07$	lsicm01
lsidem01	👶		$+0.86$	lsidem01
lsidem02	👶		$+0.77$	lsidem02
lsids01	👶		$+0.81$	lsids01
lsids02	👶		$+0.84$	lsids02
lsids03	👶		$+0.84$	lsids03
lsids04	👶		$+0.19$	lsids04
lsids05	👶		$+0.14$	lsids05
lsiex01	👶		$+0.95$	lsiex01
lsiex02	👶		$+0.63$	lsiex02
lsiex03	👶		$+1.20$	lsiex03
lsimh01	👶		$+0.89$	lsimh01
table_lbt14	💔	$4.00$	$+1.22$	LBT14_variant_3_LOW_without_baseline_missing_works_as_expected
tpk01a	👶		$+4.03$	tpk01a
tpk01bpart1	👶		$+3.61$	tpk01bpart1of2
tpk01bpart2	👶		$+3.71$	tpk01bpart2of2
tpk02part1	👶		$+9.24$	tpk02part1of2
tpk02part2	👶		$+9.52$	tpk02part2of2
tpk03	👶		$+2.83$	tpk03
tsfae01a	👶		$+2.48$	tsfae01a
tsfae01b	👶		$+1.89$	tsfae01b
tsfae02	👶		$+3.41$	tsfae02
tsfae02a	👶		$+9.71$	tsfae02a
tsfae03	👶		$+3.58$	tsfae03
tsfae03a	👶		$+8.93$	tsfae03a
tsfae04	👶		$+2.94$	tsfae04
tsfae04a	👶		$+6.41$	tsfae04a
tsfae05	👶		$+3.08$	tsfae05
tsfae05a	👶		$+5.08$	tsfae05a
tsfae06a	👶		$+5.80$	tsfae06a
tsfae06b	👶		$+18.58$	tsfae06b
tsfae07a	👶		$+2.69$	tsfae07a
tsfae07b	👶		$+2.74$	tsfae07b
tsfae08	👶		$+3.20$	tsfae08
tsfae09	👶		$+1.01$	tsfae09
tsfae10	👶		$+5.22$	tsfae10
tsfae11	👶		$+2.96$	tsfae11
tsfae12	👶		$+3.14$	tsfae12
tsfae13	👶		$+1.47$	tsfae13
tsfae14	👶		$+5.15$	tsfae14
tsfae15	👶		$+2.95$	tsfae15
tsfae16part1	👶		$+11.90$	tsfae16part1of2
tsfae16part2	👶		$+11.75$	tsfae16part2of2
tsfae17a	👶		$+3.62$	tsfae17a
tsfae17b	👶		$+2.58$	tsfae17b
tsfae17c	👶		$+4.16$	tsfae17c
tsfae17d	👶		$+3.95$	tsfae17d
tsfae19a	👶		$+0.76$	tsfae19a
tsfae19b	👶		$+0.73$	tsfae19b
tsfae19c	👶		$+1.19$	tsfae19c
tsfae19d	👶		$+1.14$	tsfae19d
tsfae20a	👶		$+1.55$	tsfae20a
tsfae20b	👶		$+1.57$	tsfae20b
tsfae20c	👶		$+1.57$	tsfae20c
tsfae21apart1	👶		$+9.28$	tsfae21apart1of4
tsfae21apart2	👶		$+8.68$	tsfae21apart2of4
tsfae21apart3	👶		$+8.75$	tsfae21apart3of4
tsfae21apart4	👶		$+8.90$	tsfae21apart4of4
tsfae21bpart1	👶		$+12.01$	tsfae21bpart1of4
tsfae21bpart2	👶		$+11.46$	tsfae21bpart2of4
tsfae21bpart3	👶		$+11.65$	tsfae21bpart3of4
tsfae21bpart4	👶		$+12.06$	tsfae21bpart4of4
tsfae21c	👶		$+6.64$	tsfae21c
tsfae21d	👶		$+8.79$	tsfae21d
tsfae22apart1	👶		$+10.50$	tsfae22apart1of4
tsfae22apart2	👶		$+10.77$	tsfae22apart2of4
tsfae22apart3	👶		$+10.03$	tsfae22apart3of4
tsfae22apart4	👶		$+10.17$	tsfae22apart4of4
tsfae22bpart1	👶		$+6.47$	tsfae22bpart1of2
tsfae22bpart2	👶		$+6.82$	tsfae22bpart2of2
tsfae22cpart1	👶		$+8.78$	tsfae22cpart1of4
tsfae22cpart2	👶		$+8.99$	tsfae22cpart2of4
tsfae22cpart3	👶		$+9.04$	tsfae22cpart3of4
tsfae22cpart4	👶		$+9.58$	tsfae22cpart4of4
tsfae23a	👶		$+0.96$	tsfae23a
tsfae23b	👶		$+0.42$	tsfae23b
tsfae23c	👶		$+0.72$	tsfae23c
tsfae23d	👶		$+0.96$	tsfae23d
tsfae24a	👶		$+0.52$	tsfae24a
tsfae24b	👶		$+0.57$	tsfae24b
tsfae24c	👶		$+2.88$	tsfae24c
tsfae24d	👶		$+3.04$	tsfae24d
tsfae24fpart1	👶		$+12.54$	tsfae24fpart1of3
tsfae24fpart2	👶		$+13.06$	tsfae24fpart2of3
tsfae24fpart3	👶		$+12.32$	tsfae24fpart3of3
tsfdth01	👶		$+1.38$	tsfdth01
tsfecg01apart1	👶		$+4.91$	tsfecg01a
tsfecg01apart2	👶		$+4.99$	tsfecg01a
tsfecg01apart3	👶		$+5.00$	tsfecg01a
tsfecg01part1	👶		$+10.19$	tsfecg01
tsfecg01part2	👶		$+9.34$	tsfecg01
tsfecg02	👶		$+3.47$	tsfecg02
tsfecg03	👶		$+0.64$	tsfecg03
tsfecg04	👶		$+2.36$	tsfecg04
tsfecg05	👶		$+1.48$	tsfecg05
tsflab01apart1	👶		$+16.06$	tsflab01a
tsflab01apart2	👶		$+14.69$	tsflab01a
tsflab01apart3	👶		$+15.12$	tsflab01a
tsflab01part1	👶		$+6.67$	tsflab01
tsflab01part2	👶		$+6.09$	tsflab01
tsflab02	👶		$+1.11$	tsflab02
tsflab02a	👶		$+2.95$	tsflab02a
tsflab02b	👶		$+2.48$	tsflab02b
tsflab03	👶		$+3.78$	tsflab03
tsflab03a	👶		$+0.03$	tsflab03a
tsflab04a	👶		$+3.01$	tsflab04a
tsflab04b	👶		$+1.30$	tsflab04b
tsflab05	👶		$+3.47$	tsflab05
tsflab06	👶		$+3.71$	tsflab06
tsflab07	👶		$+19.34$	tsflab07
tsfvit01apart1	👶		$+7.51$	tsfvit01a
tsfvit01apart2	👶		$+7.90$	tsfvit01a
tsfvit01apart3	👶		$+6.89$	tsfvit01a
tsfvit01apart4	👶		$+7.00$	tsfvit01a
tsfvit01part1	👶		$+3.50$	tsfvit01
tsfvit01part2	👶		$+3.53$	tsfvit01
tsfvit01part3	👶		$+3.60$	tsfvit01
tsfvit01part4	👶		$+3.60$	tsfvit01
tsfvit02	👶		$+0.78$	tsfvit02
tsfvit03	👶		$+0.78$	tsfvit03
tsfvit04	👶		$+0.76$	tsfvit04
tsfvit05	👶		$+2.15$	tsfvit05
tsfvit06	👶		$+0.71$	tsfvit06
tsicm01	👶		$+6.50$	tsicm01
tsicm02	👶		$+6.05$	tsicm02
tsicm03	👶		$+4.32$	tsicm03
tsicm04	👶		$+4.33$	tsicm04
tsicm05	👶		$+8.04$	tsicm05
tsicm06	👶		$+8.18$	tsicm06
tsicm07	👶		$+1.22$	tsicm07
tsicm08	👶		$+0.73$	tsicm08
tsidem01	👶		$+2.59$	tsidem01
tsidem02	👶		$+0.85$	tsidem02
tsids01	👶		$+0.43$	tsids01
tsids02	👶		$+1.70$	tsids02
tsids02a	👶		$+8.59$	tsids02a
tsiex01	👶		$+1.70$	tsiex01
tsiex02	👶		$+1.51$	tsiex02
tsiex03	👶		$+1.20$	tsiex03
tsiex04	👶		$+1.04$	tsiex04
tsiex06	👶		$+0.48$	tsiex06
tsiex07	👶		$+0.73$	tsiex07
tsiex08	👶		$+1.51$	tsiex08
tsiex09	👶		$+0.71$	tsiex09
tsiex10	👶		$+0.75$	tsiex10
tsiex11	👶		$+3.48$	tsiex11
tsimh01	👶		$+1.32$	tsimh01

Results for commit 5edc4a6

♻️ This comment has been updated with latest results.

[shajoezhu]

hi @munoztd0 , thanks for submitting the PR, i would suggest to snapshot the ascii tables instead of rtf, the table is much more readable for comparing on github, rtf is less ideal in this case. i am guessing you would like to use rtf due to output formatting?

[munoztd0]

hi @munoztd0 , thanks for submitting the PR, i would suggest to snapshot the ascii tables instead of rtf, the table is much more readable for comparing on github, rtf is less ideal in this case. i am guessing you would like to use rtf due to output formatting?

@shajoezhu I 100% agree but you're also right on your guess. If that is a blocker I could put it up the food chain but I have no hope for that.

[munoztd0]

New error on tsfae13 appeared but only on the CRAN pass, still need to investigate

[iaugusty]

@munoztd0
should our table/listing programs be pre-or-suffixed with jnj, like done for test-table_jnj_tbl1?

https://github.com/insightsengineering/scda.test/blob/main/tests/testthat/test-table_jnj_tbl1.R

[shajoezhu]

i suggest we not include rtf files here. otherwise it is going to fail always if minor changes which is not efficent, and we wont be able to test for anything. i think just create simple static snapshot is good. thanks guys!

[munoztd0]

@munoztd0 should our table/listing programs be pre-or-suffixed with jnj, like done for test-table_jnj_tbl1?

https://github.com/insightsengineering/scda.test/blob/main/tests/testthat/test-table_jnj_tbl1.R

I could do that but that would be quite a mess and also not have the same names that in internal, but lets discuss it.

[Melkiades]

Thanks for the PR! I would like to echo Joe about rtf files. It seems a bit of a fragile test considering that not everyone has the same rtf software on their machine. I strongly suggest to snapshot-test the final table and not the rtf file. Decoration details can be tested as strings if not included directly in the table.

It is important to have readable snapshots as possible changes are easier to understand and review that way. Furthermore, simple changes may have a large line changes count that would add to the .git file size. Reducing that size down after some time would be a non-trivial task.

[munoztd0]

Thanks for the PR! I would like to echo Joe about rtf files. It seems a bit of a fragile test considering that not everyone has the same rtf software on their machine. I strongly suggest to snapshot-test the final table and not the rtf file. Decoration details can be tested as strings if not included directly in the table.

It is important to have readable snapshots as possible changes are easier to understand and review that way. Furthermore, simple changes may have a large line changes count that would add to the .git file size. Reducing that size down after some time would be a non-trivial task.

I 100% agree, I will try to discuss that internally and see if I can make a case for it.. Changing the PR to draft for now,