Conversation
Unit Tests Summary3 tests 2 ✅ 4s ⏱️ Results for commit 47dc57f. ♻️ This comment has been updated with latest results. |
|
These are good changes but not complete as of now. |
|
I'll be testing with this teal PR insightsengineering/teal#1466 |
by |
All where necessary. Obviously these live in our org and include also tern and family etc. |
…nor in r-hub/actions/setup-deps
|
@pawelru so far I adjusted possible inputs that are passed to |
pawelru
left a comment
There was a problem hiding this comment.
This is a good one and I'm ok with that but please note that it's a breaking change for all the packages that are still using lookup-refs parameter! Hence not approving formally but just saying it's good but others are not ready.
Co-authored-by: Pawel Rucki <12943682+pawelru@users.noreply.github.com> Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
…tsengineering/r.pkg.template into rlib_setup_r_dependencies
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
|
A test PR in |
|
OK. This is good to go. Please make sure that all (!) the upstream packages follows - in particular: they might be passing parameters that you are about to remove! This most likely would fail the jobs. |
|
For now it runs smoothly in the PR created in I also created a card to track down all other packages insightsengineering/nestdevs-tasks#103 |
| @@ -158,12 +152,11 @@ jobs: | |||
| - name: Setup R dependencies 🎦 | |||
There was a problem hiding this comment.
Adding a comment, so it can not be merged.
It should not be merged before other packages are not suited for changes introduced in this PR.
Other packages are tracked in this card insightsengineering/nestdevs-tasks#103
Part of https://github.com/insightsengineering/coredev-tasks/issues/609