Skip to content

fix alignment x-axis for gg_km#153

Merged
Melkiades merged 6 commits intomainfrom
152_fix_alignment_gg_km_final@main
Feb 11, 2026
Merged

fix alignment x-axis for gg_km#153
Melkiades merged 6 commits intomainfrom
152_fix_alignment_gg_km_final@main

Conversation

@Melkiades
Copy link
Copy Markdown
Contributor

@Melkiades Melkiades commented Jan 12, 2026

What changes are proposed in this pull request?

  • Fix gg_km() axis alignment when annotating risk differences.

#152


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 12, 2026

Unit Tests Summary

  1 files   75 suites   1m 47s ⏱️
 75 tests  74 ✅ 1 💤 0 ❌
225 runs  224 ✅ 1 💤 0 ❌

Results for commit dfaa8be.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 12, 2026

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
tbl_hierarchical_rate_and_count 💔 $17.50$ $+1.79$ tbl_hierarchical_rate_and_count_works
tbl_hierarchical_rate_by_grade 💔 $6.70$ $+1.75$ tbl_hierarchical_rate_by_grade_works
tbl_shift 💚 $4.14$ $-1.36$ tbl_shift_strata_location_
theme_gtsummary_roche 💔 $0.67$ $+1.91$ theme_gtsummary_roche_works

Results for commit af746fd

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 12, 2026

badge

Code Coverage Summary

Filename                               Stmts    Miss  Cover    Missing
-----------------------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------
R/add_blank_rows.R                        63       0  100.00%
R/add_difference_row.R                   101       0  100.00%
R/add_hierarchical_count_row.R            33       0  100.00%
R/annotate_gg_km.R                       145       9  93.79%   86-89, 108-112
R/as_ggplot.R                             13      13  0.00%    18-38
R/crane-package.R                          2       2  0.00%    28-29
R/deprecated.R                             6       6  0.00%    15-21
R/forest.R                                68      68  0.00%    35-178
R/get_cox_pairwise_df.R                   50      13  74.00%   68-71, 74-77, 82, 92-95
R/gg_km_utils.R                          102      16  84.31%   94, 134-151, 167
R/gg_km.R                                143      37  74.13%   54-57, 74, 101, 175-180, 183-186, 196-198, 203-204, 238-240, 247-250, 254, 265-269, 282, 284-286
R/label_roche.R                           72       0  100.00%
R/modify_header_rm_md.R                   18       2  88.89%   35-36
R/modify_zero_recode.R                    13       0  100.00%
R/tbl_baseline_chg.R                     212       0  100.00%
R/tbl_hierarchical_rate_and_count.R      148       0  100.00%
R/tbl_hierarchical_rate_by_grade.R       271       3  98.89%   162-164
R/tbl_listing.R                           35       0  100.00%
R/tbl_null_report.R                        9       0  100.00%
R/tbl_roche_subgroups.R                  119     119  0.00%    34-168
R/tbl_roche_summary.R                     64       0  100.00%
R/tbl_shift.R                            116       0  100.00%
R/tbl_survfit_quantiles.R                132       1  99.24%   295
R/tbl_survfit_times.R                     92       0  100.00%
R/theme_gtsummary_roche.R                 78       0  100.00%
R/utils.R                                 36       0  100.00%
TOTAL                                   2141     289  86.50%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  -------
R/annotate_gg_km.R       +8       0  +0.36%
TOTAL                    +8       0  +0.05%

Results for commit: dfaa8be

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@Melkiades Melkiades requested a review from shajoezhu February 3, 2026 10:57
Comment thread R/annotate_gg_km.R Outdated
Signed-off-by: Davide Garolini <dgarolini@gmail.com>
@Melkiades Melkiades merged commit 54630cc into main Feb 11, 2026
31 checks passed
@Melkiades Melkiades deleted the 152_fix_alignment_gg_km_final@main branch February 11, 2026 11:29
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants