feat(tx-cache): implement Deref and DerefMut for CacheResponse<T>
#154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, we always need to call `.inner()` to access `T` on `CacheResponse`, which wraps all tx cache responses currently. With a `Deref` and `DerefMut` impl, we won't need that. Closes ENG-1673
Evalir
force-pushed
the
evalir/cacheresponse-deref
branch
from
46cee6a to
627904e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we always need to call
.inner()to accessTonCacheResponse, which wraps all tx cache responses currently. With aDerefandDerefMutimpl, we won't need that.Closes ENG-1673