Skip to content

Add synthetic data generation test to the telemetry_chargeback role #331

Merged
ayefimov-1 merged 1 commit into
masterfrom
alexy_synth_data
Jan 29, 2026
Merged

Add synthetic data generation test to the telemetry_chargeback role #331
ayefimov-1 merged 1 commit into
masterfrom
alexy_synth_data

Conversation

@ayefimov-1
Copy link
Copy Markdown
Contributor

@ayefimov-1 ayefimov-1 commented Dec 3, 2025

Add synthetic date generation to telemetry_chargeback role in FVT repo

  • Generate synthetic data and write results to a json file
  • Push json file to log directory so that during debug file is available for review
    controller/ci-framework-data/tests/feature-verification-tests
  • Do not overwrite syth data json if it already exists
  • Using Gemini and Cursor
  • Closes https://issues.redhat.com/browse/OSPRH-23746

@ayefimov-1 ayefimov-1 force-pushed the alexy_synth_data branch 2 times, most recently from 19aec46 to 8bb17cf Compare December 4, 2025 20:15
@ayefimov-1
Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/339779b18807455b8df0e0a38cd2b43d

telemetry-openstack-meta-content-provider-master FAILURE in 11m 55s
⚠️ functional-chargeback-tests-osp18 SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master

@ayefimov-1
Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8237458ee7394be68b3d919603073cc3

telemetry-openstack-meta-content-provider-master FAILURE in 11m 16s
⚠️ functional-chargeback-tests-osp18 SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master

@ayefimov-1
Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c906fc4cbd3c42f29c0f5c05fe4871d0

telemetry-openstack-meta-content-provider-master FAILURE in 12m 59s
⚠️ functional-chargeback-tests-osp18 SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master

@ayefimov-1
Copy link
Copy Markdown
Contributor Author

recheck

@ayefimov-1 ayefimov-1 force-pushed the alexy_synth_data branch 3 times, most recently from fbb6f4d to 4359403 Compare December 8, 2025 13:49
@softwarefactory-project-zuul
Copy link
Copy Markdown

This change depends on a change that failed to merge.

Change openstack-k8s-operators/telemetry-operator#319 is needed.

@ayefimov-1
Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4d9619322118449ab45fe37af8b8908f

telemetry-openstack-meta-content-provider-master FAILURE in 11m 03s
⚠️ functional-chargeback-tests-osp18 SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master

@ayefimov-1
Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ed661e9591a4423c81947c503463aa83

telemetry-openstack-meta-content-provider-master FAILURE in 11m 19s
⚠️ functional-chargeback-tests-osp18 SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4ec74750f0fc46a29a7ed1f245b406aa

telemetry-openstack-meta-content-provider-master FAILURE in 13m 56s
⚠️ functional-chargeback-tests-osp18 SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master

@ayefimov-1
Copy link
Copy Markdown
Contributor Author

recheck

@ayefimov-1 ayefimov-1 force-pushed the alexy_synth_data branch 2 times, most recently from 85f6304 to 7a32173 Compare December 9, 2025 13:39
@ayefimov-1
Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 331,7a321730f99cd73d373511f1801009bf0e15ee1b

@ayefimov-1
Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 331,7a321730f99cd73d373511f1801009bf0e15ee1b

@softwarefactory-project-zuul
Copy link
Copy Markdown

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 331,b51f59b58682b8cb2d6e5ededa0087d0ca66ad87

@ayefimov-1
Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 331,b51f59b58682b8cb2d6e5ededa0087d0ca66ad87

@ayefimov-1 ayefimov-1 force-pushed the alexy_synth_data branch 2 times, most recently from 6bd0bf0 to d984903 Compare January 14, 2026 14:27
Comment thread roles/telemetry_chargeback/files/gen_synth_loki_data.py Outdated
Comment thread roles/telemetry_chargeback/files/loki_data_templ.j2 Outdated
Comment thread roles/telemetry_chargeback/tasks/gen_synth_loki_data.yml Outdated
@ayefimov-1 ayefimov-1 force-pushed the alexy_synth_data branch 2 times, most recently from b24c576 to 98620e9 Compare January 14, 2026 22:09
@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0473894cb2f445ccbe6b054a33d1348d

telemetry-openstack-meta-content-provider-master FAILURE in 5m 27s
⚠️ functional-chargeback-tests-osp18 SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master
⚠️ functional-tests-osp18 SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master

@ayefimov-1
Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3ef27e8799e341ff980c8ff2c4d23860

✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 1h 58m 01s
✔️ functional-chargeback-tests-osp18 SUCCESS in 1h 24m 45s
functional-tests-osp18 FAILURE in 1h 39m 43s

@ayefimov-1
Copy link
Copy Markdown
Contributor Author

recheck

@ayefimov-1 ayefimov-1 requested a review from vyzigold January 15, 2026 17:32
Copy link
Copy Markdown
Contributor

@vyzigold vyzigold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the script pep8 compliant:

script.py:5:1: F401 'typing.Union' imported but unused
script.py:16:1: E302 expected 2 blank lines, found 1
script.py:33:1: E302 expected 2 blank lines, found 1
script.py:51:1: W293 blank line contains whitespace
script.py:61:23: E261 at least two spaces before inline comment
script.py:72:80: E501 line too long (88 > 79 characters)
script.py:87:80: E501 line too long (83 > 79 characters)
script.py:91:14: E261 at least two spaces before inline comment
script.py:97:1: W293 blank line contains whitespace
script.py:102:80: E501 line too long (80 > 79 characters)
script.py:108:1: E302 expected 2 blank lines, found 1
script.py:111:80: E501 line too long (84 > 79 characters)
script.py:115:80: E501 line too long (89 > 79 characters)
script.py:117:80: E501 line too long (119 > 79 characters)
script.py:120:80: E501 line too long (112 > 79 characters)
script.py:121:80: E501 line too long (105 > 79 characters)
script.py:122:1: W293 blank line contains whitespace
script.py:124:80: E501 line too long (110 > 79 characters)
script.py:147:80: E501 line too long (80 > 79 characters)

Comment thread roles/telemetry_chargeback/defaults/main.yml Outdated
@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fd6cbdc1348a4107adba1aaf937b48c1

✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 3h 39m 40s
functional-chargeback-tests-osp18 FAILURE in 1h 56m 22s
✔️ functional-tests-osp18 SUCCESS in 3h 17m 11s

@ayefimov-1
Copy link
Copy Markdown
Contributor Author

This change depends on a change that failed to merge.

Change #319 is needed.

merged

@ayefimov-1
Copy link
Copy Markdown
Contributor Author

ayefimov-1 commented Jan 21, 2026

Please make the script pep8 compliant:

script.py:5:1: F401 'typing.Union' imported but unused
script.py:16:1: E302 expected 2 blank lines, found 1
script.py:33:1: E302 expected 2 blank lines, found 1
script.py:51:1: W293 blank line contains whitespace
script.py:61:23: E261 at least two spaces before inline comment
script.py:72:80: E501 line too long (88 > 79 characters)
script.py:87:80: E501 line too long (83 > 79 characters)
script.py:91:14: E261 at least two spaces before inline comment
script.py:97:1: W293 blank line contains whitespace
script.py:102:80: E501 line too long (80 > 79 characters)
script.py:108:1: E302 expected 2 blank lines, found 1
script.py:111:80: E501 line too long (84 > 79 characters)
script.py:115:80: E501 line too long (89 > 79 characters)
script.py:117:80: E501 line too long (119 > 79 characters)
script.py:120:80: E501 line too long (112 > 79 characters)
script.py:121:80: E501 line too long (105 > 79 characters)
script.py:122:1: W293 blank line contains whitespace
script.py:124:80: E501 line too long (110 > 79 characters)
script.py:147:80: E501 line too long (80 > 79 characters)

fixed pep8 compliance for gen_synth_loki_data.py and loki_data_templ.j2

Copy link
Copy Markdown
Contributor

@vyzigold vyzigold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also fix the few long lines that are left (see the comments inline) unless we want to agree to ignore line lengths or extend the max length, which would also be fine by me as long as we have some wider agreement about it @elfiesmelfie wdyt?

After that this PR LGTM.

Comment thread roles/telemetry_chargeback/files/gen_synth_loki_data.py Outdated
Comment thread roles/telemetry_chargeback/files/gen_synth_loki_data.py Outdated
Comment thread roles/telemetry_chargeback/files/gen_synth_loki_data.py Outdated
Comment thread roles/telemetry_chargeback/files/gen_synth_loki_data.py Outdated
@ayefimov-1
Copy link
Copy Markdown
Contributor Author

Let's also fix the few long lines that are left (see the comments inline) unless we want to agree to ignore line lengths or extend the max length, which would also be fine by me as long as we have some wider agreement about it @elfiesmelfie wdyt?

After that this PR LGTM.

Done

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f971f7a2964b452e9b1e206b18272129

✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 2h 47m 17s
functional-chargeback-tests-osp18 FAILURE in 1h 22m 21s
functional-tests-osp18 FAILURE in 2h 29m 39s

@ayefimov-1
Copy link
Copy Markdown
Contributor Author

ayefimov-1 commented Jan 26, 2026

tempest failure in test_list_containers

@ayefimov-1
Copy link
Copy Markdown
Contributor Author

recheck

Copy link
Copy Markdown
Contributor

@myadla myadla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Json log has every second entry is missing the timestamp entirely. Please make changes to make sure it is present in every entry

https://logserver.rdoproject.org/7a7/rdoproject.org/7a7edc3dfb2b4e1493050c6369d3c3a4/controller/ci-framework-data/tests/feature-verification-tests/gen_loki_synth_data.log

Comment thread roles/telemetry_chargeback/README.md Outdated
Comment thread roles/telemetry_chargeback/README.md Outdated
Comment thread roles/telemetry_chargeback/README.md Outdated
Comment thread roles/telemetry_chargeback/defaults/main.yml Outdated
Comment thread roles/telemetry_chargeback/files/test_static.yml Outdated
Comment thread roles/telemetry_chargeback/tasks/chargeback_tests.yml Outdated
Comment thread roles/telemetry_chargeback/tasks/gen_synth_loki_data.yml Outdated
@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/57edf3e4e02a4866b28eb1565e359ea4

✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 2h 16m 12s
✔️ functional-chargeback-tests-osp18 SUCCESS in 1h 28m 59s
✔️ feature-verification-tests-noop SUCCESS in 5s
functional-tests-osp18 FAILURE in 1h 47m 35s

Comment thread roles/telemetry_chargeback/vars/main.yml
  Generate synthetic data and write results to a json file

  Push json file to log directory so that during debug file is available for review

  Controller/ci-framework-data/tests/feature-verification-tests

  Do not overwrite syth data json if it already exists

  Using Gemini and Cursor

  Closes https://issues.redhat.com/browse/OSPRH-23746

  Update the synthetic data generation process to ensure that existing JSON files are not overwritten. This change allows for better debugging by preserving previous data outputs.

Closes https://issues.redhat.com/browse/OSPRH-23746
Copy link
Copy Markdown
Contributor

@myadla myadla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified the changes in my PR#332 and I'm able to push the data successfully..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review This change is ready for review

Development

Successfully merging this pull request may close these issues.

5 participants