line chart shadow option #561
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added one option to dataset shadowColor: similar to color, if not provided, shadow color for the dataset will be the same as the line color with useShadowColorFromDataset:true, if useShadowColorFromDataset:false, shadow color will be chartConfig.color. shadow color is applied with following priority. dataset.shadowColor -> dataset.color -> chartConfig.color
Hermanya
reviewed
Feb 8, 2022
| }; | ||
|
|
||
| getShadowColor = (dataset: Dataset, opacity: number) => { | ||
| return (dataset.shadowColor || dataset.color || this.props.chartConfig.color)(opacity); |
Contributor
There was a problem hiding this comment.
I feel like it should default to url(#fillShadowGradient..., to make this change backwards compatible
Hermanya
requested changes
Feb 8, 2022
Contributor
Hermanya
left a comment
Hermanya
left a comment
There was a problem hiding this comment.
this change looks like it would change behaviour for existing users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added one option to dataset
shadowColor: similar to color, if not provided, shadow color for the dataset will be the same as the line color with useShadowColorFromDataset:true,
if useShadowColorFromDataset:false,
shadow color will be chartConfig.color.
shadow color is applied with following priority.
dataset.shadowColor -> dataset.color -> chartConfig.color