fix(api): improve error handling and add timeouts to edit_page endpoint#98
Open
Avalanche-ag wants to merge 1 commit into
Open
fix(api): improve error handling and add timeouts to edit_page endpoint#98Avalanche-ag wants to merge 1 commit into
Avalanche-ag wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current
/api/edit_pageendpoint does not do input validation and assumes thattargetUrlis always in the correct format. If it is malformed or missing,re.findalland the regex matcher crash the backend with anIndexErrororTypeError. Furthermore, therequestslibrary calls are made with notimeout, risking the server hanging indefinitely if the wikimedia API is temporarily unreachable.Solution
This PR hardens the
/api/edit_pagecode natively.requestURLandcontent.timeout=10on target API fetch and pushes.Related Tasks
Adresses the Backend Error Handling & Observability micro-task goals outline in T415715.