Skip to content

fix(flatcover) report progress on the number of specs, not package names #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
indexzero merged 2 commits into from
Jan 27, 2026
Merged

fix(flatcover) report progress on the number of specs, not package names #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df75c98
fix(flatcover) report progress on the number of specs, not package names
indexzero Jan 21, 2026
1725aeb
fix(words) s/packages/package specs/
indexzero Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions bin/flatcover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ async function* checkCoverage(deps, { registry, auth, token, progress }) {

const packages = [...byPackage.entries()];
let completed = 0;
const total = packages.length;
const total = deps.length;

// Process in batches for bounded concurrency
for (let i = 0; i < packages.length; i += concurrency) {
Expand Down Expand Up @@ -353,10 +353,10 @@ async function* checkCoverage(deps, { registry, auth, token, progress }) {
for (const packageResults of results) {
for (const result of packageResults) {
yield result;
}
completed++;
if (progress) {
process.stderr.write(`\r Checking: ${completed}/${total} packages`);
completed++;
if (progress) {
process.stderr.write(`\r Checking: ${completed}/${total} package specs`);
}
}
}
}
Expand Down