Fix broken Cargo.toml: tonic/tower/tracing moved outside [dependencies]#9
Merged
Conversation
The [package.metadata.cargo-machete] section was inserted in the middle of the [dependencies] block, causing tonic, tower, and tracing to be parsed as metadata rather than dependencies. Move the metadata section below the dependency declarations. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Update tantivy rev to match the merged indextables/tantivy main so that the quickwit workspace and tantivy4java use the same tantivy version, avoiding duplicate crates in the dependency graph. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[package.metadata.cargo-machete]section added in Upgrade to upstream quickwit main; point tantivy dep at upgrade/tantivy-0.26 #8 was inserted in the middle of the[dependencies]block inquickwit-common/Cargo.toml[section-header]as starting a new section, sotonic,tower, andtracingwere silently parsed as metadata rather than dependenciesunresolved import tracing/tower/tonicerrors when compiling as a git dependency from external cratesTest plan
cargo checkpasses in tantivy4java after pinning to the new commit🤖 Generated with Claude Code