-
Notifications
You must be signed in to change notification settings - Fork 4
feat(textInput): add emoji filtering by default for text inputs #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
diglesias17
wants to merge
5
commits into
indec-it:develop
Choose a base branch
from
diglesias17:feature/disable-emojis
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2b21f47
feat(textInput): add emoji filtering by default for text inputs
diglesias17 0c94ed3
feat(textInput): moves regexp to constants and improves method names
diglesias17 aed9c09
feat(textInput): adds unit tests for emojis treatment
diglesias17 a5a8616
feat(textInput): fixes eslint issues
diglesias17 2147762
feat(textInput): fixes import issue
diglesias17 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,6 +43,34 @@ describe('handleChangeText', () => { | |
| should(result.answer).be.undefined(); | ||
| }); | ||
| }); | ||
|
|
||
| context('with an answer including emojis', () => { | ||
| it('should sanitize it by default', () => { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Excelente! |
||
| let result = ''; | ||
| handleChangeText( | ||
| { | ||
| name: 'answer' | ||
| }, | ||
| 'answer with \ud83c\udff4', | ||
| value => result = value | ||
| ); | ||
| result.answer.should.be.String(); | ||
| result.answer.should.be.equal('answer with '); | ||
| }); | ||
| it('should not sanitize it if allowEmojis is set to true', () => { | ||
| let result = ''; | ||
| handleChangeText( | ||
| { | ||
| name: 'answer', | ||
| allowEmojis: true | ||
| }, | ||
| 'answer with \ud83c\udff4', | ||
| value => result = value | ||
| ); | ||
| result.answer.should.be.String(); | ||
| result.answer.should.be.equal('answer with \ud83c\udff4'); | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahora que lo veo mejor, hace lo mismo que el
formatValue()👀.Se puede simplificar más si concantenás las regex en una sola: https://stackoverflow.com/a/185529. Lo interesante ahora va a ser que el test siga dando verde cuando modifiques la implementación, prescindiendo del
sanitize().