Cast $count from string to int#5
Open
dejdav wants to merge 4 commits intoin2code-de:masterfrom
dejdav:master
Open
Cast $count from string to int#5dejdav wants to merge 4 commits intoin2code-de:masterfrom dejdav:master
dejdav wants to merge 4 commits intoin2code-de:masterfrom
dejdav:master
Conversation
Author
|
I would be glad if you could publish a new release that includes this pull request. |
Author
|
Hi, I fixed another issue in commit dcb7898. The callback function ( |
sbusemann
reviewed
Aug 31, 2019
Contributor
sbusemann
left a comment
There was a problem hiding this comment.
@vertexvaar is there a reason, why we did not use the TYPO3 API?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I noticed that the
ResultStatement::fetchColumn()function returns either astringor abooleanbut the return value is compared with=== 0in the code which requires the variable to be aninteger(as0 == '0'evaluates totruebut0 === '0'evaluates tofalsein PHP). Therefore i suggest casting the$countvariable fromstringtoint. Otherwise it is impossible to create a new backend user on the client TYPO3 instance because the SQLINSERTstatement is never executed. In order to reproduce this issue simply delete the backend user on the client TYPO3 instance and try to log in as that user once again. The T3AM authentication will not work because the backend user is not inserted into thebe_userstable. I referenced the relevant code line below.t3am/Classes/UserRepository.php
Line 277 in 6e5e799