Skip to content

Add link to Aquarium on landing page#2

Open
DikieDick wants to merge 1 commit into
masterfrom
feat/addLinkToAquarium
Open

Add link to Aquarium on landing page#2
DikieDick wants to merge 1 commit into
masterfrom
feat/addLinkToAquarium

Conversation

@DikieDick
Copy link
Copy Markdown
Contributor

Adds a link to Aquarium to the impermeable landing page.

Currently looks like:

image

Remarks

As a follow up I think we should rework the entire right side, for example the Installation text should maybe be h3 instead of h2 to indicate this is part of the VSCode extension section. Should we also indicate more clearly that the VSCode extension is the preferred way of using Waterproof?

Copy link
Copy Markdown
Contributor

@jim-portegies jim-portegies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's wonderful when we can do this. I am wondering if we can bring it in a bit more prominently.

Comment thread index.html
</p>
<ul id="try-out-online">
<li>
<p class="lead"></p><a href="https://impermeable.github.io/aquarium"><img id="impermeable-logo-button" src="assets/druppel.png" alt="impermeable logo">In the browser</a></p>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p class="lead"></p><a href="https://impermeable.github.io/aquarium"><img id="impermeable-logo-button" src="assets/druppel.png" alt="impermeable logo">In the browser</a></p>
<p class="lead"></p><a href="https://impermeable.github.io/aquarium"><img id="impermeable-logo-button" src="assets/druppel.png" alt="impermeable logo">Directly in the browser</a></p>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we should bring the name "aquarium" forward more prominently

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't think so, but if we do, I think we should use "Waterproof Aquarium", because the Waterproof brand is starting to take off a bit, and I think we want to reinforce that.

@pimotte
Copy link
Copy Markdown

pimotte commented May 12, 2026

Thanks! It's wonderful when we can do this. I am wondering if we can bring it in a bit more prominently.

I'd be happy if we merged this as is, but I think the messaging we want to express here is: If you just want to quickly see what Waterproof is, use the aquarium, if you intend to use it a lot/run your own course/run into performance issues, use the vscode extension.

I'm not really sure how to communicate that succinctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants