fix(passport): remove toUserImx validation from registerOffchain #2766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix critical regression introduced in commit 240cd2f that blocks new users from registering with ImmutableX. Problem: - registerOffchain() now validates IMX metadata (via toUserImx) BEFORE calling the registration workflow - New users don't have IMX metadata until AFTER registration completes - This creates a Catch-22: users need metadata to register, but need to register to get metadata Impact: - All new users on SDK v2.12.0+ cannot register with ImmutableX - Existing users (registered before Dec 8, 2025) are unaffected Solution: - Pass User directly instead of toUserImx(user) to registerOffchain workflow - Metadata validation happens AFTER registration in forceUserRefresh() - Restores pre-240cd2f behavior Evidence: - Kerry (created Dec 3) registered successfully before bug - Brandon (created Jan 12) blocked after bug was introduced Tests: - Added test for new user registration without IMX metadata - All tests pass
|
View your CI Pipeline Execution ↗ for commit cc05702
☁️ Nx Cloud last updated this comment at |
JCSanPedro
approved these changes
Jan 13, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical regression introduced in commit 240cd2f that blocks new users from registering with ImmutableX.
Problem
registerOffchain()validates IMX metadata (viatoUserImx) BEFORE calling the registration workflowImpact
Solution
Userdirectly instead oftoUserImx(user)toregisterOffchainworkflowforceUserRefresh()Evidence
Changes
passportImxProvider.ts: removedtoUserImx()call on line 184Testing
Related
Note
Restores new-user registration by adjusting
registerOffchainto accept rawUserrather thantoUserImx(user).passportImxProvider.tsto passuserintoregisterOffchain, avoiding premature IMX metadata validationpassportImxProvider.test.tscovering: registration for users without IMX metadata, already-registered users, andgetAddresserror when metadata is missingWritten by Cursor Bugbot for commit cc05702. This will update automatically on new commits. Configure here.