Skip to content

Fix some missing VST3 PClassInfo2 properties #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilmai merged 1 commit into from
Apr 16, 2026
Merged

Fix some missing VST3 PClassInfo2 properties #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion plinth-plugin/src/formats/vst3/factory.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ impl<P: Vst3Plugin + 'static> Factory<P> {
.to_com_ptr::<IPluginFactory>()
.unwrap()
.into_raw() as _
}
}
}

impl<P: Vst3Plugin> vst3::Class for Factory<P> {
Expand Down Expand Up @@ -112,11 +112,19 @@ impl<P: Vst3Plugin + 'static> IPluginFactory2Trait for Factory<P> {

copy_u128_to_char8(&P::CLASS_ID, &mut local_info.cid);
copy_str_to_char8(P::NAME, &mut local_info.name);
copy_str_to_char8(P::VENDOR, &mut local_info.vendor);
copy_str_to_char8(P::VERSION, &mut local_info.version);

copy_str_to_char8("Audio Module Class", &mut local_info.category);
copy_str_to_char8(unsafe { CStr::from_ptr(SDKVersionString).to_str().unwrap() }, &mut local_info.sdkVersion);

let subcategory_string = P::SUBCATEGORIES
.iter()
.map(|subcategory| subcategory.to_str())
.collect::<Vec<_>>()
.join("|");
copy_str_to_char8(&subcategory_string, &mut local_info.subCategories);

// We have to do a workaround like this for FL Studio which is giving us unaligned addresses
unsafe { std::ptr::write_unaligned(info, local_info) };

Expand All @@ -136,6 +144,7 @@ impl<P: Vst3Plugin + 'static> IPluginFactory3Trait for Factory<P> {

copy_u128_to_char8(&P::CLASS_ID, &mut local_info.cid);
copy_str_to_char16(P::NAME, &mut local_info.name);
copy_str_to_char16(P::VENDOR, &mut local_info.vendor);
copy_str_to_char16(P::VERSION, &mut local_info.version);

copy_str_to_char8("Audio Module Class", &mut local_info.category);
Expand Down