chore: implicit assignments

R/community.R

@@ -1095,7 +1095,8 @@ as.dendrogram.communities <- function(
     object$height <- object$modularity[-1]
     object$height <- cumsum(object$height - min(object$height))
   }
-  nMerge <- length(oHgt <- object$height)
+  oHgt <- object$height
+  nMerge <- length(oHgt)
   if (nMerge != nrow(merges)) {
     cli::cli_abort("'merge' and 'height' do not fit!")
   }
@@ -1105,7 +1106,8 @@ as.dendrogram.communities <- function(
   leafs <- nrow(merges) + 1
   for (k in 1:nMerge) {
     x <- merges[k, ] # no sort() anymore!
-    if (any(neg <- x < leafs + 1)) {
+    neg <- (x < (leafs + 1))
+    if (any(neg)) {
       h0 <- if (hang < 0) 0 else max(0, oHgt[k] - hang * hMax)
     }
     if (all(neg)) {
@@ -1154,7 +1156,8 @@ as.dendrogram.communities <- function(
         2
     }
     attr(zk, "height") <- oHgt[k]
-    z[[k <- format(k + leafs, scientific = FALSE)]] <- zk
+    k <- format(k + leafs, scientific = FALSE)
+    z[[k]] <- zk
   }
   z <- z[[k]]
   class(z) <- "dendrogram"

R/hrg.R

@@ -569,9 +569,12 @@ as.dendrogram.igraphHRG <- function(object, hang = 0.01, ...) {
 
   for (k in 1:nMerge) {
     x <- merges[k, 1:2]
-    if (any(neg <- x >= 0)) {
+    neg <- (x >= 0)
+
+    if (any(neg)) {
       h0 <- if (hang < 0) 0 else max(0, oHgt[k] - hang * hMax)
     }
+
     if (all(neg)) {
       # two leaves
       zk <- as.list(x + 1)
@@ -607,7 +610,8 @@ as.dendrogram.igraphHRG <- function(object, hang = 0.01, ...) {
         2
     }
     attr(zk, "height") <- oHgt[k]
-    z[[k <- paste0("g", -merges[k, 3])]] <- zk
+    k <- paste0("g", -merges[k, 3])
+    z[[k]] <- zk
   }
   z <- z[[k]]
   class(z) <- "dendrogram"

R/par.R

@@ -224,13 +224,18 @@ igraph_i_options <- function(..., .in = parent.frame()) {
   temp <- list(...)
   if (length(temp) == 1 && is.null(names(temp))) {
     arg <- temp[[1]]
-    switch(
-      mode(arg),
-      list = temp <- arg,
-      character = return(.igraph.pars[arg]),
+
+    if (mode(arg) == "character") {
+      return(.igraph.pars[arg])
+    }
+
+    if (mode(arg) != "list") {
       cli::cli_abort("invalid argument: {arg}.")
-    )
+    }
+
+    temp <- arg
   }
+
   if (length(temp) == 0) {
     return(get_all_options())
   }

tests/testthat/test-assortativity.R

@@ -1,3 +1,5 @@
+# jarl-ignore-file implicit_assignment: just the way it works
+
 test_that("assortativity works", {
   g <- read_graph(f <- gzfile("celegansneural.gml.gz"), format = "gml")
 

tests/testthat/test-foreign.R

@@ -1,3 +1,4 @@
+# jarl-ignore-file implicit_assignment: just the way it works
 test_that("writing Pajek files works", {
   # FIXME: Does the Pajek format allow for \r\n line endings on Windows?
   # Adapt test depending on that.

tests/testthat/test-plot.shapes.R

@@ -1,4 +1,4 @@
-# Test shapes() function
+# jarl-ignore-file implicit_assignment: just the way it works
 test_that("shapes() lists all available shapes", {
   all_shapes <- shapes()
   expect_type(all_shapes, "character")