Update project structure #1
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the project structure by centralizing package management and updating build configurations. The changes migrate from a traditional Visual Studio solution file to a modern .slnx format while consolidating package versions and build properties into Directory.Build.props and Directory.Packages.props files.
- Centralized package version management using Directory.Packages.props
- Moved common build properties to Directory.Build.props for inheritance across all projects
- Updated to .NET 9.0 and modernized build scripts to use dotnet CLI
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/Linq.Expressions.Deconstruct.Tests.csproj | Removed explicit package versions and build properties (now inherited) |
| SourceGenerators/ToExprGenerator.cs | Added nullable annotations to method signature and null-forgiving operators |
| SourceGenerators/SourceGenerators.csproj | Removed explicit package versions and build properties |
| Source/Linq.Expressions.Deconstruct.csproj | Removed explicit package versions and build properties |
| Linq.Expressions.Deconstruct.slnx | Added new XML-based solution file format |
| Linq.Expressions.Deconstruct.sln | Removed traditional solution file |
| Directory.Packages.props | Added centralized package version management |
| Directory.Build.props | Added common build properties for all projects |
| Build.cmd | Updated build script to use dotnet CLI instead of MSBuild |
| .github/workflows/dotnet.yml | Updated .NET version to 9.0.x and simplified workflow |
| cd /d "%~dp0" | ||
| "%ProgramFiles%\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\MSBuild.exe" Linq.Expressions.Deconstruct.sln /p:Configuration=Release /t:Restore;Rebuild /v:m | ||
| "%ProgramFiles%\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\MSBuild.exe" Linq.Expressions.Deconstruct.sln /p:Configuration=Debug /t:Restore;Rebuild /v:m | ||
| cd /d "%~dp0" |
There was a problem hiding this comment.
The build script retains the old MSBuild approach in comments but doesn't remove them. Consider removing the commented lines to avoid confusion about which build approach to use.
| uses: actions/setup-dotnet@v3 | ||
| with: | ||
| dotnet-version: 8.0.x | ||
| dotnet-version: 9.0.x |
There was a problem hiding this comment.
Updating to .NET 9.0.x may introduce compatibility issues since your knowledge cutoff is January 2025 and it's now June 2025. Consider verifying that all dependencies and target frameworks are compatible with .NET 9.0.
| dotnet-version: 9.0.x | |
| dotnet-version: 9.0.x | |
| - name: Verify compatibility | |
| run: dotnet list package --outdated |
No description provided.