Skip to content

Conversation

@igerber
Copy link
Owner

@igerber igerber commented Jan 26, 2026

Summary

  • Bump version from 2.1.8 to 2.1.9 in __init__.py, pyproject.toml, and rust/Cargo.toml
  • Add CHANGELOG entry for v2.1.9 documenting PR Add unified LOOCV for TROP joint method with Rust acceleration #113 changes:
    • Unified LOOCV for TROP joint method with Rust acceleration
    • TROP joint method Rust/Python parity fixes (valid_count bug, NaN handling, jackknife fixes)

Methodology references (required if estimator / math changes)

  • Method name(s): N/A - version bump only, no methodology changes
  • Paper / source link(s): N/A
  • Any intentional deviations from the source (and why): None

Validation

  • Tests added/updated: No test changes (version bump only)
  • Backtest / simulation / notebook evidence (if applicable): N/A

Security / privacy

  • Confirm no secrets/PII in this PR: Yes

Generated with Claude Code

Update version numbers in:
- diff_diff/__init__.py
- pyproject.toml
- rust/Cargo.toml

Add CHANGELOG entry for v2.1.9 documenting TROP joint method
improvements including unified LOOCV with Rust acceleration and
various Rust/Python parity fixes from PR #113.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions
Copy link

Overall assessment: ⚠️ Needs changes

Executive Summary

  • Changelog for 2.1.9 lists substantive TROP LOOCV/variance behavior changes; ensure those changes are already merged and documented, or adjust the release notes to match this PR’s contents.
  • Reviewed docs/methodology/REGISTRY.md; no estimator or inference code changes in this diff to verify against registry requirements.
  • Version bumps are consistent across diff_diff/__init__.py, pyproject.toml, and rust/Cargo.toml.

Methodology

  • Severity: P2 | Impact: Release notes assert TROP estimator, variance/SE, and assumption handling changes, but this PR contains only version/changelog edits, so methodology adherence cannot be verified and the release notes may be misleading if those changes are not already merged | Concrete fix: Confirm the referenced changes are already in the codebase and aligned with docs/methodology/REGISTRY.md/TROP docstrings; otherwise update the changelog to reflect the actual contents of this release. Location: CHANGELOG.md:L8-L23

Code Quality

  • No findings.

Performance

  • No findings.

Maintainability

  • No findings.

Tech Debt

  • No findings.

Security

  • No findings.

Documentation/Tests

  • No findings.

@igerber igerber merged commit 36b57d0 into main Jan 26, 2026
5 checks passed
@igerber igerber deleted the release/v2.1.9 branch January 26, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants