PWA Service Workers #718
Open
samikabhatkar-web wants to merge 3 commits into
Open
Conversation
samikabhatkar-web
temporarily deployed
to
staging-718
GitHub Actions
Inactive
TheAbubakrAbu
requested changes
May 12, 2026
Collaborator
TheAbubakrAbu
left a comment
TheAbubakrAbu
left a comment
There was a problem hiding this comment.
Great job guys!
But one small thing, ratings is currently using NETWORK_FIRST. Because ratings can change frequently and stale ratings could be misleading, I think we should move ratings into the NEVER_CACHE block like what you did with favorites.
Contributor
Author
Sounds good, I moved the user-specific ones (dish.rated, user.getUserRating) to NEVER_CACHE and leftdish.getAverageRating in NETWORK_FIRST. |
TheAbubakrAbu
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Next.js static asset and CSS caching to the service worker
Changes
/_next/static/to the static assets cache block to catch Next.js compiled CSS and JS chunksinstallevent listener to pre-cache the app shell and icons on service worker installfetchAndCacheandisCacheFreshhelper functions for reusable caching logicfetchevent listenerTesting Instructions
*Although, I think next.js might not be handling the service workers
Closes #